[Libosinfo] [PATCHv4 06/11] Add OsinfoInstallConfig:config-params property

Christophe Fergeau cfergeau at redhat.com
Thu Dec 20 15:13:01 UTC 2012


On Thu, Dec 20, 2012 at 05:07:23PM +0200, Zeeshan Ali (Khattak) wrote:
> On Wed, Dec 19, 2012 at 5:43 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> If I understood your current patch series correctly,
> OsinfoInstallConfig:config-params is not set before app generates the
> script so:
> 
> 1. by the time OsinfoInstallConfig:config-params is set,
> OsinfoInstallConfig is unlikely to be useful to the app anymore.
> 2. it would be totally unintuitive for app to have access to
> OsinfoInstallConfig:config-params only after generating the script.
> 
> Now if you want to revisit the decision to make
> osinfo_install_config_new_for_script() private, that is another thing.
> Otherwise, I really don't see what you want to achieve with exposing
> OsinfoInstallConfig:config-params in public API.

Please read again the last paragraph of
https://www.redhat.com/archives/libosinfo/2012-December/msg00049.html
as well as
https://www.redhat.com/archives/libosinfo/2012-December/msg00052.html

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20121220/c7add703/attachment.sig>


More information about the Libosinfo mailing list