[Libosinfo] [PATCH 4/4] Add install script for RHEL 6.3

[Zeeshan Ali (Khattak)]

On Sun, Dec 23, 2012 at 12:50 PM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Sat, Dec 22, 2012 at 06:20:57AM +0200, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>>
>> The same script might work for other versions too but I have only made
>> it work against RHEL 6.3 for now. Still some issues though:
>
> I'd expect the same script to work from 6.0 onward with no changes or very
> minimal ones, so I'd rather we add this script to all RHEL6 versions.

Yeah.

> I'm also wondering if it would make sense to share the same script between
> RHEL and Fedora? (maybe with a different script for Fedora >= 18).

I thought of that but we'll need a lot of conditionals and it'd
wouldn't look nice. So I'd prefer we keep it separate.

> Also, when diffing this script against the fedora script, I see the
> spice-vdagent and xorg-x11-drv-qxl drivers are not listed. I assume they
> are installed by default with RHEL, but I thought this was the case for
> Fedora as well?

Don't remember if they are installed by default on Fedora but they are
definitely installed by default on RHEL 6.

>> diff --git a/data/install-scripts/rhel.xml b/data/install-scripts/rhel.xml
>> new file mode 100644
>> index 0000000..ce2edf0
>> --- /dev/null
>> +++ b/data/install-scripts/rhel.xml
>> @@ -0,0 +1,204 @@
>> +<libosinfo version="0.0.1">
>> +  <!-- JEOS PROFILE -->
>> +  <install-script id='http://redhat.com/scripts/rhel/jeos'>
>> +    <profile>jeos</profile>
>> +    <expected-filename>fedora.ks</expected-filename>
>> +    <config>
>> +      <param name="admin-password" policy="optional"/>
>> +      <param name="l10n-keyboard" policy="optional"/>
>> +      <param name="l10n-language" policy="optional"/>
>> +      <param name="l10n-timezone" policy="optional"/>
>> +      <param name="target-disk" policy="optional"/>
>
> Looking at the fedora/rhel diff, I get the impression target-disk is not
> supported in the RHEL script for now, and that the reference to it in the
> 'clearpart' call should not be there.

I don't understand. 'clearparts' needs device files and thats what we
are providing it:

https://access.redhat.com/knowledge/docs/en-US/Red_Hat_Enterprise_Linux/5/html/Installation_Guide/s1-kickstart2-options.html

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124