[Libosinfo] [PATCH] rhel: Fix a typo causing infinit loops/recursion

Christophe Fergeau cfergeau at redhat.com
Thu Dec 27 13:12:41 UTC 2012


On Thu, Dec 27, 2012 at 03:00:35PM +0200, Zeeshan Ali (Khattak) wrote:
> On Sun, Dec 23, 2012 at 12:59 PM, Christophe Fergeau
> <cfergeau at redhat.com> wrote:
> > On Fri, Dec 21, 2012 at 07:15:00PM +0200, Zeeshan Ali (Khattak) wrote:
> >> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> >>
> >> RHEL 6.3 derives from 6.2, not 6.3 itself.
> >> ---
> >>  data/oses/rhel.xml.in | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/data/oses/rhel.xml.in b/data/oses/rhel.xml.in
> >> index 8a4f8de..12d4a02 100644
> >> --- a/data/oses/rhel.xml.in
> >> +++ b/data/oses/rhel.xml.in
> >> @@ -757,8 +757,8 @@
> >>      <family>linux</family>
> >>      <distro>rhel</distro>
> >>      <codename>Santiago</codename>
> >> -    <upgrades id="http://redhat.com/rhel/6.3"/>
> >> -    <derives-from id="http://redhat.com/rhel/6.3"/>
> >> +    <upgrades id="http://redhat.com/rhel/6.2"/>
> >> +    <derives-from id="http://redhat.com/rhel/6.2"/>
> >
> > Is this something we could add a test for in the test suite so that we
> > don't introduce similar bugs in the future?
> 
> Since the DB could also come from outside, I think more useful would
> to add warning/assert in loader.

If this can be caught from there, works for me.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20121227/62e1fddd/attachment.sig>


More information about the Libosinfo mailing list