[Libosinfo] [PATCH 2/2] win8: Add install script

[Christophe Fergeau]

On Thu, Dec 27, 2012 at 10:23:10PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> 
> Using the desktop profile, I was able to do an express installation
> against GNOME Boxes.
> 
> I'm adding a seperate script for windows 8 rather than re-using the
> existing unattended.xml we have for windows 7 because windows 8 requires
> product key to be specified while it remains option for windows 7.

You make it sound like 99% of the file is duplicated expect for this
optional/required product key. Could we avoid this duplication through some
XML includes?
> +        <xsl:template name="language">
> +          <xsl:variable name="language">
> +            <xsl:value-of select="config/l10n-language"/>
> +          </xsl:variable>
> +          <xsl:variable name="formatted-language">
> +            <xsl:value-of select="translate($language,'_','-')"/>
> +          </xsl:variable>
> +          <xsl:choose>
> +            <xsl:when test="contains($formatted-language,'.')">
> +              <xsl:value-of select="substring-before($formatted-language,'.')"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:value-of select="$formatted-language"/>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>

Would be a good opportunity to follow up on
https://www.redhat.com/archives/virt-tools-list/2012-December/msg00160.html
...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20121227/b6162885/attachment.sig>