[Libosinfo] [libosinfo 1/4] db: Add device names next to the device IDs

[Zeeshan Ali (Khattak)]

On Wed, Apr 3, 2013 at 11:08 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Wed, Apr 03, 2013 at 09:58:04AM +0200, Christophe Fergeau wrote:
>> Adding the device names in XML comments make the driver declaration
>> much clearer in windows.xml
>> ---

ACK

>>  data/oses/windows.xml.in | 48 ++++++++++++++++++++++++------------------------
>>  1 file changed, 24 insertions(+), 24 deletions(-)
>>
>> diff --git a/data/oses/windows.xml.in b/data/oses/windows.xml.in
>> index 26d4410..2262497 100644
>> --- a/data/oses/windows.xml.in
>> +++ b/data/oses/windows.xml.in
>> @@ -407,11 +407,11 @@
>>        <file>spice-guest-tools-0.52.cmd</file>
>>        <file>redhat09.cer</file>
>>        <file>redhat10.cer</file>
>> -      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
>> -      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
>> -      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1002"/>
>> -      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1003"/>
>> -      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1b36/0100"/>
>> +      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/> <!-- virtio-net -->
>> +      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/> <!-- virtio-block -->
>> +      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1002"/> <!-- virtio-balloon -->
>> +      <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1003"/> <!-- virtio-serial -->
>
> Note that I've used virtio-serial throughout this patch, while other places
> in libosinfo use virtio-console. My understanding is that virtio-console
> is just the 'historical' name. I can add a patch changing the name
> everywhere if virtio-serial is indeed better, or I can change the name in
> this patch if we want to stick with virtio-console.

I have the same understanding so I'd rather update virtio-console
reference everywhere.


--
Regards,

Zeeshan Ali (Khattak)
FSF member#5124