[Libosinfo] [v2 8/8] winxp, installer: Make use of post-installation drivers

[Christophe Fergeau]

On Sun, Feb 10, 2013 at 06:41:09PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> 
> ---
>  data/install-scripts/windows-cmd.xml | 18 ++++++++++++++++++
>  data/install-scripts/windows-sif.xml |  2 ++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/data/install-scripts/windows-cmd.xml b/data/install-scripts/windows-cmd.xml
> index 85aae12..1a9cd47 100644
> --- a/data/install-scripts/windows-cmd.xml
> +++ b/data/install-scripts/windows-cmd.xml
> @@ -4,6 +4,9 @@
>      <profile>desktop</profile>
>      <path-format>dos</path-format>
>      <expected-filename>windows.cmd</expected-filename>
> +    <can-post-install-drivers>true</can-post-install-drivers>
> +    <post-install-drivers-signing-req>strict-mutable</post-install-drivers-signing-req>
> +    <post-install-driver-format>script</post-install-driver-format>
>      <config>
>        <param name="admin-password" policy="optional"/>
>        <param name="user-realname" policy="required"/>
> @@ -11,6 +14,8 @@
>        <param name="avatar-disk" policy="optional"/>
>        <param name="target-disk" policy="optional"/>
>        <param name="script-disk" policy="optional"/>
> +      <param name="post-install-drivers-disk" policy="optional"/>
> +      <param name="post-install-drivers-location" policy="optional"/>
>      </config>
>      <avatar-format>
>        <mime-type>image/bmp</mime-type>
> @@ -46,6 +51,17 @@
>            </xsl:choose>
>          </xsl:template>
>  
> +        <xsl:template name="post-install-drivers-disk">
> +          <xsl:choose>
> +            <xsl:when test="config/post-install-drivers-disk != ''">
> +              <xsl:value-of select="config/post-install-drivers-disk"/>
> +            </xsl:when>
> +            <xsl:otherwise>
> +              <xsl:text>A</xsl:text>
> +            </xsl:otherwise>
> +          </xsl:choose>
> +        </xsl:template>
> +
>  	<xsl:template match="/install-script-config">
>  sc config TlntSvr start= auto
>  net user <xsl:value-of select="config/user-realname"/> <xsl:text> </xsl:text> <xsl:value-of select="config/admin-password"/> /add /passwordreq:no
> @@ -53,6 +69,8 @@ net localgroup administrators <xsl:value-of select="config/user-realname"/> /add
>  net accounts /maxpwage:unlimited
>  if not "<xsl:value-of select="config/avatar-location"/>"=="" copy "<xsl:value-of select="config/avatar-disk"/>:<xsl:value-of select="config/avatar-location"/>" "<xsl:call-template name="target-disk"/>:\Documents and Settings\All Users\Application Data\Microsoft\User Account Pictures\<xsl:value-of select="config/user-realname"/>.bmp"
>  REGEDIT /S <xsl:call-template name="script-disk"/>:\windows.reg
> +<xsl:call-template name="post-install-drivers-disk"/>:
> +for %%i in ("<xsl:call-template name="post-install-drivers-disk"/>:<xsl:value-of select="config/post-install-drivers-location"/>\*.cmd") do %%i

I'm still not a huge fan of the *.cmd here (and in retrospect, I don't know
if having a .cmd makes things much better than having an *.exe /s there,
though this makes things more flexible).
We could add a node to the <driver> node to explicity give the command that
should be run, but I'm not sure this would be very convenient to do in
xslt?
Something that I feel is missing from this series is some kind of
osinfo_xxx_set_drivers_to_install(GList *drivers); to explicitly tell
libosinfo about what we want it to do during install, then we could avoid
the *.cmd/*.exe /s there. Just thinking out loud, I don't really know what
is the best way forward at this point...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20130214/774d3966/attachment.sig>