[Libosinfo] [v3 5/5] winxp, installer: Make use of post-installation drivers

[Zeeshan Ali (Khattak)]

On Fri, Feb 15, 2013 at 8:15 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Fri, Feb 15, 2013 at 04:54:11AM +0200, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>>
>> ---
>>  data/install-scripts/windows-cmd.xml | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>
>> diff --git a/data/install-scripts/windows-cmd.xml b/data/install-scripts/windows-cmd.xml
>> index 85aae12..3dafc50 100644
>> --- a/data/install-scripts/windows-cmd.xml
>> +++ b/data/install-scripts/windows-cmd.xml
>> @@ -4,6 +4,8 @@
>>      <profile>desktop</profile>
>>      <path-format>dos</path-format>
>>      <expected-filename>windows.cmd</expected-filename>
>> +    <can-post-install-drivers>true</can-post-install-drivers>
>> +    <post-install-drivers-signing-req>none</post-install-drivers-signing-req>
>>      <config>
>>        <param name="admin-password" policy="optional"/>
>>        <param name="user-realname" policy="required"/>
>> @@ -11,6 +13,8 @@
>>        <param name="avatar-disk" policy="optional"/>
>>        <param name="target-disk" policy="optional"/>
>>        <param name="script-disk" policy="optional"/>
>> +      <param name="post-install-drivers-disk" policy="optional"/>
>> +      <param name="post-install-drivers-location" policy="optional"/>
>>      </config>
>>      <avatar-format>
>>        <mime-type>image/bmp</mime-type>
>> @@ -46,6 +50,17 @@
>>            </xsl:choose>
>>          </xsl:template>
>>
>> +        <xsl:template name="post-install-drivers-disk">
>> +          <xsl:choose>
>> +            <xsl:when test="config/post-install-drivers-disk != ''">
>> +              <xsl:value-of select="config/post-install-drivers-disk"/>
>> +            </xsl:when>
>> +            <xsl:otherwise>
>> +              <xsl:text>A</xsl:text>
>> +            </xsl:otherwise>
>> +          </xsl:choose>
>> +        </xsl:template>
>> +
>>       <xsl:template match="/install-script-config">
>>  sc config TlntSvr start= auto
>>  net user <xsl:value-of select="config/user-realname"/> <xsl:text> </xsl:text> <xsl:value-of select="config/admin-password"/> /add /passwordreq:no
>> @@ -53,6 +68,10 @@ net localgroup administrators <xsl:value-of select="config/user-realname"/> /add
>>  net accounts /maxpwage:unlimited
>>  if not "<xsl:value-of select="config/avatar-location"/>"=="" copy "<xsl:value-of select="config/avatar-disk"/>:<xsl:value-of select="config/avatar-location"/>" "<xsl:call-template name="target-disk"/>:\Documents and Settings\All Users\Application Data\Microsoft\User Account Pictures\<xsl:value-of select="config/user-realname"/>.bmp"
>>  REGEDIT /S <xsl:call-template name="script-disk"/>:\windows.reg
>> +<xsl:call-template name="post-install-drivers-disk"/>:
>> +reg add "HKCU\Software\Policies\Microsoft\Windows NT\Driver Signing" /v BehaviorOnFailedVerify /t reg_dword /d 00000000 /f
>> +for %%i in ("<xsl:call-template name="post-install-drivers-disk"/>:<xsl:value-of select="config/post-install-drivers-location"/>\*.cmd") do cmd /k %%i
>
>
> Not a blocker for this patch, but does this open cmd.exe windows while
> installing the drivers?

Yeah but that gets open anyways for this script itself AFAICT. It's a
bit difficult to actively monitor this as this script is executed at
the very end of installation and there is no way i can sit and wait
for that to happen. :)

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124