[Libosinfo] [PATCHv4 06/11] Add OsinfoInstallConfig:config-params property

[Zeeshan Ali (Khattak)]

On Fri, Jan 4, 2013 at 12:01 PM, Michal Privoznik <mprivozn at redhat.com> wrote:
> On 31.12.2012 17:20, Zeeshan Ali (Khattak) wrote:
>> On Thu, Dec 20, 2012 at 6:45 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>>> This property lists the parameters that can be set for a given
>>> OsinfoInstallConfig. This is not enforced, it's only there for
>>> informative purpose. This will also be used in later commits
>>> in order to automatically apply transformations on values
>>> for parameters which have an associated OsinfoDatamap.
>>
>> Sorry to revive this thread again but I had an idea that I wanted to
>> discuss before this API goes into a release: How about we have a
>> OsinfoInstallConfig:install-script (of type OsinfoInstallScript)
>> rather than having OsinfoInstallConfig:config-params (and
>> 'path-format', 'avatar-format' etc) duplicated on both objects? IMO
>> that makes a lot more sense since that not only avoids duplication of
>> API (and some strings) but also makes things more clear: Whether a
>> config is associated/specific to a script or not? If it is, which
>> install script is exactly its tied to?
>>
>>
>>
>
> Right. I prefer OsinfoInstallConfig:install-script as well. The more
> inheritance the better IMO in this case.

As much as I'd like to see other developers agree with my suggestion,
I feel that there is a miscommunication here: The ':' in the GObject
world (especially when talking of C code/API) denotes property rather
than inheritance.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124