[Libosinfo] [PATCHv4 06/11] Add OsinfoInstallConfig:config-params property

[Zeeshan Ali (Khattak)]

On Mon, Jan 7, 2013 at 4:46 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> On Mon, Dec 31, 2012 at 2:20 PM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
>> On Thu, Dec 20, 2012 at 6:45 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>>> This property lists the parameters that can be set for a given
>>> OsinfoInstallConfig. This is not enforced, it's only there for
>>> informative purpose. This will also be used in later commits
>>> in order to automatically apply transformations on values
>>> for parameters which have an associated OsinfoDatamap.
>>
>> Sorry to revive this thread again but I had an idea that I wanted to
>> discuss before this API goes into a release: How about we have a
>> OsinfoInstallConfig:install-script (of type OsinfoInstallScript)
>> rather than having OsinfoInstallConfig:config-params (and
>> 'path-format', 'avatar-format' etc) duplicated on both objects? IMO
>> that makes a lot more sense since that not only avoids duplication of
>> API (and some strings) but also makes things more clear: Whether a
>> config is associated/specific to a script or not? If it is, which
>> install script is exactly its tied to?
>
>
> After a long read of the topic, personally, I agree with Zeeshan's
> suggestion, basically because it contributes for clearness.
> However, I think we should wait Christophe's opinion (he is on vacations, IIRC).

Sure thing, I have been waiting for that. However, we'll be needing a
release at the end of this week (or next monday) for Boxes and being
API stable, we wont be able to change the API after wards. I-e we only
got this week to get this done.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124