[Libosinfo] [PATCH v2] Add install script for RHEL 6.x

[Zeeshan Ali (Khattak)]

On Wed, Jan 9, 2013 at 2:44 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> On Tue, Jan 8, 2013 at 10:27 PM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
>> On Wed, Jan 9, 2013 at 1:43 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>>> On Tue, Jan 8, 2013 at 9:23 PM, Zeeshan Ali (Khattak)
>>> <zeeshanak at gnome.org> wrote:
>>>> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>>>>
>>>> The same script might work for other RHEL 6.x too but I have only tested
>>>> it against RHEL 6.3 for now. Still some issues though:
>>>>
>>>> 1. For some reason user's avatar is ignored although according to the docs
>>>> I could find*, copying the avatar to /home/${USER}/.face should be
>>>> enough.
>>>>
>>>> 2. We don't set the keyboard layout properly yet and just hardcode it to
>>>>   'us'. This will require the same kind of mapping as Fedora 17 and older.
>>>>
>>>> * http://projects.gnome.org/gdm/docs/2.14/configuration.html
>>>> ---
>>>>  data/install-scripts/Makefile.am |   1 +
>>>>  data/install-scripts/rhel.xml    | 204 +++++++++++++++++++++++++++++++++++++++
>>>>  data/oses/rhel.xml.in            |  20 ++++
>>>>  3 files changed, 225 insertions(+)
>>>>  create mode 100644 data/install-scripts/rhel.xml
>>>>
>>>> diff --git a/data/install-scripts/Makefile.am b/data/install-scripts/Makefile.am
>>>> index cb24e09..c310468 100644
>>>> --- a/data/install-scripts/Makefile.am
>>>> +++ b/data/install-scripts/Makefile.am
>>>> @@ -2,6 +2,7 @@
>>>>  databasedir = $(pkgdatadir)/db/install-scripts/
>>>>  database_DATA =     \
>>>>    fedora.xml        \
>>>> +  rhel.xml          \
>>>>    windows-sif.xml   \
>>>>    windows-cmd.xml   \
>>>>    windows-reg.xml   \
>>>> diff --git a/data/install-scripts/rhel.xml b/data/install-scripts/rhel.xml
>>>> new file mode 100644
>>>> index 0000000..9c17f11
>>>> --- /dev/null
>>>> +++ b/data/install-scripts/rhel.xml
>>>> @@ -0,0 +1,204 @@
>>>> +<libosinfo version="0.0.1">
>>>> +  <!-- JEOS PROFILE -->
>>>> +  <install-script id='http://redhat.com/scripts/rhel/jeos'>
>>>> +    <profile>jeos</profile>
>>>> +    <expected-filename>fedora.ks</expected-filename>
>>>> +    <config>
>>>> +      <param name="admin-password" policy="optional"/>
>>>> +      <param name="l10n-keyboard" policy="optional"/>
>>>> +      <param name="l10n-language" policy="optional"/>
>>>> +      <param name="l10n-timezone" policy="optional"/>
>>>> +      <param name="target-disk" policy="optional"/>
>>>> +    </config>
>>>> +    <template>
>>>> +      <xsl:stylesheet
>>>> +        xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
>>>> +        version="1.0">
>>>> +
>>>> +        <xsl:output method="text"/>
>>>> +
>>>> +        <xsl:template name="target-disk">
>>>> +          <xsl:choose>
>>>> +            <xsl:when test="config/target-disk != ''">
>>>> +              <xsl:value-of select="config/target-disk"/>
>>>> +            </xsl:when>
>>>> +            <xsl:when test="os/version > 4">
>>>> +              <!-- virtio -->
>>>> +              <xsl:text>/dev/vda</xsl:text>
>>>> +            </xsl:when>
>>>> +            <xsl:otherwise>
>>>> +              <!-- IDE -->
>>>> +              <xsl:text>/dev/sda</xsl:text>
>>>> +            </xsl:otherwise>
>>>> +          </xsl:choose>
>>>> +        </xsl:template>
>>>> +
>>>> +        <xsl:template match="/install-script-config">
>>>> +# Install script for <xsl:value-of select="os/short-id"/> profile <xsl:value-of select="script/profile"/>
>>>> +install
>>>> +text
>>>> +<!-- FIXME: RHEL requires keyboard layout to be a console layout so to do this right, we'll need
>>>> +            mapping from language to console layout. -->
>>>> +keyboard us
>>>> +lang <xsl:value-of select="config/l10n-language"/>
>>>> +skipx
>>>> +network --device eth0 --bootproto dhcp
>>>> +rootpw <xsl:value-of select="config/admin-password"/>
>>>> +firewall --disabled
>>>> +authconfig --enableshadow --enablemd5
>>>> +selinux --enforcing
>>>> +timezone --utc <xsl:value-of select="config/l10n-timezone"/>
>>>> +bootloader --location=mbr
>>>> +zerombr
>>>> +
>>>> +clearpart --all --drives=<xsl:call-template name="target-disk"/>
>>>
>>> According with: https://bugzilla.gnome.org/show_bug.cgi?id=676537#c12
>>> JeOS scripts should be identical to scripts provided by:
>>> https://github.com/clalancette/oz/tree/master/oz/auto
>>>
>>> So, if the script works properly without "--drives=...", remove it
>>> from JeOS profile.
>>
>> Rationale?
>
> Again, "According with: https://bugzilla.gnome.org/show_bug.cgi?id=676537#c12"

Ouch, I missed the link. In that context, I think Daniel was trying to
explain the difference and more appropriate word would have been "very
similar". Daniel can clarify if I got it wrong.

> IMHO, go ahead with your patch. *If* needed, we can change this in the
> future, once the script was tested and is working (consider this an
> ACK).

Yeah, even if I'm wrong about what Daniel meant, its not like our
other jeos scripts are identical to that of Oz's either.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124