[Libosinfo] [PATCH 8/8] winxp, installer: Make use of post-installation drivers

[Zeeshan Ali (Khattak)]

On Mon, Jan 28, 2013 at 3:14 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Jan 28, 2013 at 05:18:47AM +0200, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>>
>> ---
>>  data/install-scripts/windows-cmd.xml | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/data/install-scripts/windows-cmd.xml b/data/install-scripts/windows-cmd.xml
>> index 85aae12..0288394 100644
>> --- a/data/install-scripts/windows-cmd.xml
>> +++ b/data/install-scripts/windows-cmd.xml
>> @@ -4,6 +4,9 @@
>>      <profile>desktop</profile>
>>      <path-format>dos</path-format>
>>      <expected-filename>windows.cmd</expected-filename>
>> +    <can-post-install-drivers>true</can-post-install-drivers>
>> +    <can-post-install-unsigned-drivers>true</can-post-install-unsigned-drivers>
>> +    <post-install-driver-format>executable</post-install-driver-format>
>>      <config>
>>        <param name="admin-password" policy="optional"/>
>>        <param name="user-realname" policy="required"/>
>> @@ -11,6 +14,8 @@
>>        <param name="avatar-disk" policy="optional"/>
>>        <param name="target-disk" policy="optional"/>
>>        <param name="script-disk" policy="optional"/>
>> +      <param name="post-install-drivers-disk" policy="optional"/>
>> +      <param name="post-install-drivers-location" policy="optional"/>
>>      </config>
>>      <avatar-format>
>>        <mime-type>image/bmp</mime-type>
>> @@ -46,6 +51,17 @@
>>            </xsl:choose>
>>          </xsl:template>
>>
>> +        <xsl:template name="post-install-drivers-disk">
>> +          <xsl:choose>
>> +            <xsl:when test="config/post-install-drivers-disk != ''">
>> +              <xsl:value-of select="config/post-install-drivers-disk"/>
>> +            </xsl:when>
>> +            <xsl:otherwise>
>> +              <xsl:text>A</xsl:text>
>> +            </xsl:otherwise>
>> +          </xsl:choose>
>> +        </xsl:template>
>> +
>>       <xsl:template match="/install-script-config">
>>  sc config TlntSvr start= auto
>>  net user <xsl:value-of select="config/user-realname"/> <xsl:text> </xsl:text> <xsl:value-of select="config/admin-password"/> /add /passwordreq:no
>> @@ -53,6 +69,7 @@ net localgroup administrators <xsl:value-of select="config/user-realname"/> /add
>>  net accounts /maxpwage:unlimited
>>  if not "<xsl:value-of select="config/avatar-location"/>"=="" copy "<xsl:value-of select="config/avatar-disk"/>:<xsl:value-of select="config/avatar-location"/>" "<xsl:call-template name="target-disk"/>:\Documents and Settings\All Users\Application Data\Microsoft\User Account Pictures\<xsl:value-of select="config/user-realname"/>.bmp"
>>  REGEDIT /S <xsl:call-template name="script-disk"/>:\windows.reg
>> +for %%i in ("<xsl:call-template name="post-install-drivers-disk"/>:<xsl:value-of select="config/post-install-drivers-location"/>\*.exe") do %%i /S
>
> You can't expect every possible Windows exe file to honour the /S switch.

If a binary doesn't support '/S' switch, it will ignore it?

> I'd tend to go with a list of files + a .cmd file which contains the actual
> commands to run (osinfo-*.cmd would be even better but I'm not 100% sure
> Windows accept such wildcards).
> This would let us handle .msi file, unpacked drivers should be possible too
> with an appropriate .cmd file, ...

This would mean that either us or the driver setup distributor will
have to provide a cmd file with it?


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124