[Libosinfo] [PATCHv2 3/4] installer, win7: Adapt windows-cmd.xml for Windows 7

[Zeeshan Ali (Khattak)]

On Fri, Mar 1, 2013 at 5:12 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Feb 28, 2013 at 02:18:54AM +0200, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>>
>> On Windows 7, we need to make use of integrated bcdedit.exe to enable
>> test signing and disable integrity checks before we could attempt to
>> install (possibly) unsigned drivers. We use the same app to disable test
>> signing and enable integrity checks after installing drivers.
>>
>> Since bcdedit.exe does not exist in Window XP, we don't use it on that
>> OS. Moreover, since the registry key manipulation on Windows 7 does not
>> help anything, we better not fiddle with those on Windows 7 as doing so
>> is always discouraged.
>>
>> Also since the certutil.exe thats used by driver's .cmd file to add
>> driver publisher to trusted list does not exist on Windows XP, we have to
>> continue resorting to registry fiddling to enable installation of drivers
>> from untrusted publishers for Windows XP.
>> ---
>>  data/install-scripts/windows-cmd.xml | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/data/install-scripts/windows-cmd.xml b/data/install-scripts/windows-cmd.xml
>> index 7a56846..569df30 100644
>> --- a/data/install-scripts/windows-cmd.xml
>> +++ b/data/install-scripts/windows-cmd.xml
>> @@ -61,16 +61,37 @@
>>          </xsl:template>
>>
>>       <xsl:template match="/install-script-config">
>> +<xsl:if test="os/version < 6.1">
>>  sc config TlntSvr start= auto
>>  net user <xsl:value-of select="config/user-realname"/> <xsl:text> </xsl:text> <xsl:value-of select="config/admin-password"/> /add /passwordreq:no
>>  net localgroup administrators <xsl:value-of select="config/user-realname"/> /add
>>  net accounts /maxpwage:unlimited
>>  if not "<xsl:value-of select="config/avatar-location"/>"=="" copy "<xsl:value-of select="config/avatar-disk"/>:<xsl:value-of select="config/avatar-location"/>" "<xsl:call-template name="target-disk"/>:\Documents and Settings\All Users\Application Data\Microsoft\User Account Pictures\<xsl:value-of select="config/user-realname"/>.bmp"
>>  REGEDIT /S <xsl:call-template name="script-disk"/>:\windows.reg
>> +</xsl:if>
>> +
>>  <xsl:call-template name="post-install-drivers-disk"/>:
>> +<xsl:choose>
>> +  <xsl:when test="os/version < 6.1">
>
> 6.1 is Windows 7 if I'm not mistaken, for at least Windows Vista you want
> to use the bcdedit method as well
> (http://www.overclock.net/t/187919/how-to-disable-driver-signature-enforcement-in-vista
> ), so I'd use 6.0 here.

ACK. Lets look into enabling this for Vista after this too.

> Using a win7-drivers.cmd and winxp-drivers.cmd could make this windows.cmd
> script more readable, but not really urgent.

Either that or see if any of the other commands could work for win7 as
well. Adding avatar to win7 installs has been on my todo for a while
now. Anyways, I'll push this now and work that after wards if you
don't mind.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124