[Libosinfo] [PATCH 01/11] fedora, rhel, installer: Don't use "--activate" with older OSes

[Fabiano Fidêncio]

On Mon, Mar 25, 2013 at 9:46 AM, Christophe Fergeau <cfergeau at redhat.com>wrote:

> Hey,
>
> Can we not just drop it rather than making it conditional?
> http://fedoraproject.org/wiki/Anaconda/Kickstart#network says
> 'Device of the first network command is activated if network is required,
> e.g. in case of network installation or using vnc. Activation of the device
> can be also explicitly required by --activate option.'
>
> so it would seem this will be done automatically if needed?
>

Yes, after a few tests here I can say you are right.
Should I resend the patch?


> On Sat, Mar 23, 2013 at 03:09:24PM +0100, Fabiano Fidêncio wrote:
> > ---
> >  data/install-scripts/fedora.xml | 2 +-
> >  data/install-scripts/rhel.xml   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/data/install-scripts/fedora.xml
> b/data/install-scripts/fedora.xml
> > index 6e8a92d..0d14b28 100644
> > --- a/data/install-scripts/fedora.xml
> > +++ b/data/install-scripts/fedora.xml
> > @@ -216,7 +216,7 @@ reboot
> >  install
> >  keyboard '<xsl:call-template name="keyboard"/>'
> >  lang <xsl:value-of select="config/l10n-language"/>
> > -network --onboot yes --device eth0 --bootproto dhcp --noipv6
> --hostname=<xsl:value-of select="config/hostname"/> --activate
> > +network --onboot yes --device eth0 --bootproto dhcp --noipv6
> --hostname=<xsl:value-of select="config/hostname"/> <xsl:if
> test="os/version > 16">--activate</xsl:if>
> >  rootpw dummyPa55w0rd # Actual password set (or unset) in %post below
> >  firewall --disabled
> >  authconfig --enableshadow --enablemd5
> > diff --git a/data/install-scripts/rhel.xml
> b/data/install-scripts/rhel.xml
> > index 9c17f11..5942826 100644
> > --- a/data/install-scripts/rhel.xml
> > +++ b/data/install-scripts/rhel.xml
> > @@ -124,7 +124,7 @@ reboot
> >  install
> >  keyboard us
> >  lang <xsl:value-of select="config/l10n-language"/>
> > -network --onboot yes --device eth0 --bootproto dhcp --noipv6
> --hostname=<xsl:value-of select="config/hostname"/> --activate
> > +network --onboot yes --device eth0 --bootproto dhcp --noipv6
> --hostname=<xsl:value-of select="config/hostname"/> <xsl:if
> test="os/version > 6.0">--activate</xsl:if>
> >  rootpw dummyPa55w0rd # Actual password set (or unset) in %post below
> >  firewall --disabled
> >  authconfig --enableshadow --enablemd5
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > Libosinfo mailing list
> > Libosinfo at redhat.com
> > https://www.redhat.com/mailman/listinfo/libosinfo
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
>
>


-- 
Fabiano Fidêncio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20130330/de42415d/attachment.htm>