[Libosinfo] [PATCH] win7: Generalize volume-id for professional

[Christophe Fergeau]

----- Mail original -----
> On Thu, Apr 24, 2014 at 9:13 AM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> >
> >
> >> Generalize volume-id to include 'N SP1' variant.
> >
> > More descriptive log would have been nice, I had to stare at the diff for a
> > bit to make sense of it :(
> 
> I don't think commit log is supposed to be a translation of code
> changes into English but rather an explanation and rationale (if
> needed). Having said that, I would have made an exception here if I
> had realized that change isn't so obvious.

All I was saying was that the short log was too terse to make it easy to understand without looking at the code. A slightly more verbose log in addition to the short log could have made what the change is about more obvious.

Christophe