[Libosinfo] [PATCH] fedora: Adjust initrd/kernel paths to real file

[Lasse Schuirmann]

2014-05-30 12:24 GMT+02:00 Zeeshan Ali (Khattak) <zeeshanak at gnome.org>:
> On Fri, May 30, 2014 at 9:52 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> On Thu, May 29, 2014 at 07:44:57PM +0200, Lasse Schuirmann wrote:
>>> What is the hardlink and what is the "real file" is determined during
>>> the compression process nondeterministically. (To be exact the first
>>> occurrence will be the "real" file [entry + body] and the following
>>> will be only the entries without body in this archive format IIRC.)
>>> That is the reason while the paths of the 32 bit iso and the 64 bit
>>> iso differ.
>>
>> This sounds like something that will need to be updated with every new
>> releases rather than having some somehow fixed path. This was also a
>> non-issue when Boxes was using iso-read, but is now more complicated
>> since it chose to switch to libarchive (but not impossible). From a
>> quick reading of libarchive page about link handling, I'm under the
>> impression that it's writing which is hard, I'm not sure reading is that
>> complicated, and I think reading is enough in the Fedora case.
>>
>> Short version: I don't think this is a great change, and this is
>> something Boxes can/should handle, so NACK from me.
>
> Hmm.. good points. Thanks for chimming in. :)
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
> ________________________________________
> Befriend GNOME: http://www.gnome.org/friends/

I have implemented the hardlink support in Boxes so it is no problem anymore
for us. I think it may be a problem for other people using libosinfo.
You have to
download the ISO anyway to make the new entry, I don't see why it is difficult
to just choose the "real" file (its the only one that is named appropriately and
doesn't seem to have a size of 0 bytes in file-roller).

I think it's just friendly forward to the users of libosinfo. (I do
agree that this patch
is quite optional!) It also improves performance a bit for the users since they
may have to reiterate through the archive again to follow the hardlink.

Just state whether you want this patch or not, in case I'll refine it for you.

Greetings,

Lasse