[Libosinfo] [PATCH v2 3/4] osinfo_loader: replace some xpath queries with direct data access
Giuseppe Scrivano
gscrivan at redhat.com
Wed Jun 4 09:53:34 UTC 2014
Eric Blake <eblake at redhat.com> writes:
> On 06/03/2014 12:19 PM, Giuseppe Scrivano wrote:
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>
>> - for (i = 0 ; i < nrelated ; i++) {
>> - gchar *id = (gchar *)xmlGetProp(related[i], BAD_CAST "id");
>> + for(it = root->children; it; it = it->next) {
>
> Style nit - isn't there supposed to be a space after 'for' ?
thanks to have catched it. Fixed in my local version.
I was hoping for "make syntax-check" to catch this kind of errors, but
the rule wasn't there.
This should help in future:
https://www.redhat.com/archives/libosinfo/2014-June/msg00025.html
Regards,
Giuseppe
More information about the Libosinfo
mailing list