[Libosinfo] [PATCH 3/3] debian: Add desktop installation script

[Christophe Fergeau]

On Mon, Jun 23, 2014 at 01:02:31PM +0200, Lasse Schuirmann wrote:
> 2014-06-22 18:21 GMT+02:00 Giuseppe Scrivano <gscrivan at redhat.com>:
> > Lasse Schuirmann <lasse.schuirmann at gmail.com> writes:
> >
> >> ---
> >>  data/install-scripts/debian.xml | 174 ++++++++++++++++++++++++++++++++++++++++
> >>  data/oses/debian.xml.in         |   1 +
> >>  2 files changed, 175 insertions(+)
> >>
> >> diff --git a/data/install-scripts/debian.xml b/data/install-scripts/debian.xml
> >> index e08b86b..2d4c3bc 100644
> >> --- a/data/install-scripts/debian.xml
> >> +++ b/data/install-scripts/debian.xml
> >> @@ -103,4 +103,178 @@ d-i finish-install/reboot_in_progress note
> >>        </xsl:stylesheet>
> >>      </template>
> >>    </install-script>
> >> +
> >> +  <!-- DESKTOP PROFILE -->
> >> +  <install-script id='http://debian.org/scripts/debian/desktop'>
> >> +    <profile>desktop</profile>
> >> +    <expected-filename>preseed.cfg</expected-filename>
> >> +    <can-pre-install-drivers>true</can-pre-install-drivers>
> >> +    <config>
> >> +      <!-- Localization options -->
> >> +      <param name="l10n-keyboard" policy="optional" value-map="http://libosinfo.fedorahosted.org/x11-keyboard"/>
> >> +      <param name="l10n-language" policy="optional"/>
> >> +      <param name="l10n-timezone" policy="optional"/>
> >> +
> >> +      <!-- User options -->
> >> +      <param name="user-login" policy="required"/>
> >> +      <param name="user-fullname" policy="optional"/>
> >> +      <!-- This MUST be nonempty. Can we enforce this? -->
> >> +      <param name="user-password" policy="required"/>
> >> +      <param name="admin-password" policy="required"/>
> >> +
> >> +      <!-- Misc -->
> >> +      <param name="hostname" policy="optional"/>
> >> +      <param name="domain" policy="optional"/>
> >> +      <param name="target-disk" policy="optional"/>
> >> +    </config>
> >> +    <injection-method>initrd</injection-method>
> >> +    <needs-internet-connection>true</needs-internet-connection>
> >
> > can't it be installed from other sources so to not require an internet
> > connection, like DVD iso images?  Or does "needs-internet-connection"
> > mean something different?
> >
> > Regards,
> > Giuseppe
> 
> The problem with this debian desktop installation script is the
> desktop. The following is true:
> - The debian ISOs with different UIs included have the same volume ID;
> the only possibility to differentiate between variants would be the
> file name or a look into the archive
> - I found no preseed command to install the UI that is present on the ISO
>   - The standard desktop package (tasksel tasksel/first multiselect
> desktop) refers to gnome, which is not included in most variants
>   - If I don't select a desktop package explicitly no desktop is
> installed (at least on the ISOs I tested.)
> 
> So in order to get a desktop independently from the variant an
> internet connection is needed to download it.
> 
> I can include some comment in the commit log or code about that.

This definitely belongs in the commit log so that people wondering in
the future why we have 'needs-internet' in this script know why it's
present. Did you file some bugs against debian describing the issues you
had ?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20140624/b4aa882b/attachment.sig>