[Libosinfo] [PATCH] loader: Negative loop bound

[Fabiano Fidêncio]

On Mon, May 26, 2014 at 10:52 AM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> On Sat, May 24, 2014 at 02:49:39AM +0200, Fabiano Fidêncio wrote:
> > osinfo_loader_nodeset() can return -1 without set an error
>
> Do you have more details about the scenario in which it occurs? It seems
> this can only happen happening through one of the
> g_return_val_if_fail()?
>

You're right, this is the only possible scenario.


> g_return_if_fail() are used to flag programmers' errors, after such an
> error is reported, behaviour is undefined, so we generally don't try to
> handle them.
>

I tried to handle the g_return_var_if_fail().
If we generally don't try to handle then, just ignore the patch.

Best Regards,
-- 
Fabiano Fidêncio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20140526/b4b926f1/attachment.htm>