[Libosinfo] [PATCH 2/2] win7: Add virtual kbd & mouse to supported devices

[Zeeshan Ali (Khattak)]

On Wed, Apr 15, 2015 at 3:37 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Wed, Apr 15, 2015 at 03:29:33PM +0100, Zeeshan Ali (Khattak) wrote:
>> On Wed, Apr 15, 2015 at 2:59 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Tue, Mar 31, 2015 at 08:34:43PM +0100, Zeeshan Ali (Khattak) wrote:
>> >> While Microsoft Windows XP is known to crash early on during
>> >> installation if USB keyboard and mouse are detected,
>> >
>> > I just created a VM in virt-manager, made sure USB keyboard/mouse were
>> > there, and I've been able to successfully complete that install. Could
>> > the bug be coming from somewhere else and not directly related to
>> > winxp+usb? I did not find any mention of such crashes online either (but
>> > I did not look too much).
>>
>> Oh? Its possible it was a combination of some other config that Boxes
>> sets. You did reproduce this crash in Boxes two weeks back so at least
>> I'm not imagining it. :) In any case, I think these patches are still
>> good.
>
> What we really want to express is "this OS supports this class of input
> devices". Your patches describe a specific type of USB mouse, and then
> QEMU will present a different USB mouse to guests, this is very
> inconsistent at best.

I don't think the inconsistency is significant enough and is not
actually introduced by these patches themselves. Libosinfo is just
saying "these devices are supported by the OS" with these patches and
if Boxes or qemu (or other apps) add a slightly different device based
on this information, that is not a fault of libosinfo.

> So if we can do without because the bug is elsewhere, it's better imo.

That would mean very slow keyboard and mouse in windows 8.1.

The bug of XP installer crashing is not exactly somewhere else since
we at least know that it does not happen if you only remove USB mouse
and keyboard from Boxes generated domain configuration. As I said, its
likely a combination, USB mouse and keyboard being a part of that. In
any case, Boxes has already been modified to only add these devices if
they are known to work fine on the OS.

However, if you prefer I can modify the patches to add the exact model
that qemu uses, even if they are not even registered to usb.ids.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/