[Libosinfo] [PATCH 2/2] win7: Add virtual kbd & mouse to supported devices

[Zeeshan Ali (Khattak)]

On Thu, Apr 16, 2015 at 4:44 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Apr 16, 2015 at 04:23:56PM +0100, Zeeshan Ali (Khattak) wrote:
>> On Thu, Apr 16, 2015 at 3:56 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > On Thu, Apr 16, 2015 at 02:52:27PM +0100, Zeeshan Ali (Khattak) wrote:
>> >> On Wed, Apr 15, 2015 at 5:02 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> >> > On Wed, Apr 15, 2015 at 04:01:46PM +0100, Zeeshan Ali (Khattak) wrote:
>> >> >> I don't think the inconsistency is significant enough and is not
>> >> >> actually introduced by these patches themselves. Libosinfo is just
>> >> >> saying "these devices are supported by the OS" with these patches and
>> >> >> if Boxes or qemu (or other apps) add a slightly different device based
>> >> >> on this information, that is not a fault of libosinfo.
>> >> >
>> >> > Yes, this would be Boxes/qemu faults for not following what libosinfo
>> >> > told it to and adding a USB mouse when libosinfo never told it this
>> >> > specific mouse was supported. In this patch what you really are trying
>> >> > to say is that it's able to support any USB mouse, not the VMWare one.
>> >>
>> >> Huh? How so? Your last sentence is contradicting the previous one.
>> >
>> > This patch is adding a specific device definition (QEMU supports a
>> > specific USB mouse provided by VMWare).
>> > What you need/really want in this series is a way to say "QEMU supports
>> > HID devices whose protocol is "Mouse" "
>>
>> Sure, how do I do that?
>
> New <device-class> node?

So we go through the pain of adding new API to honour a
differentiation that we know is unlikely to be significant? I don't
think that is a good idea.

If you want me to add the exact devices that qemu uses, I'm willing to
do that or we can go with these patches. Just tell me which you
prefer.

> The next issue here is that saying that Windows XP does not support USB
> mouses/keyboard is incorrect. The magic knowledge encoding that XP automatic
> installation should not use USB keyboard/mouse would make more sense in
> libvirt-designer/libvirt-builder (or Boxes in the mean time).

Sure, I will update commit log.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/