[Libosinfo] [PATCH 07/12] test: Replace F19 & F21 Alpha ISO data w/ released

[Zeeshan Ali (Khattak)]

On Mon, Mar 16, 2015 at 10:14 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Sun, Mar 15, 2015 at 04:04:54PM +0000, Zeeshan Ali (Khattak) wrote:
>> Both F19 and F21 has been released. Not only its better to keep test
>
> it's
>
>> data against released ISOs rather than Alpha ISOs, the volume-size is
>> obviously different between released and Alpha ISO so if we want to add
>> volume-size for these ISOs to our database, we need this change to avoid
>> breaking the tests.
>
> If I understand correctly, this means that after this series, some media
> entries which were detected by libosinfo (Fedora Alphas) will no longer
> be recognized?

Correct.

> Do we want a 'catch-all' entry without specifying a size?
> Or provide a way to do 'fuzzy' identification where the size would be
> ignored for ISO detection? "This looks like a Fedora 19 ISO" when the
> byte size is off by one is much better than "I don't know what ISO this
> is".

My thinking was that we don't really need to care about those ISOs now
that they have been long obsoleted. As you can probably see through
the changes, it took me quite a while to make these changes so I was
obviously being lazy to go that extra mile to keep supporting those
ISOs.

Anyway, do we really want to keep supporting those ISOs?

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/