[Libosinfo] [PATCH 0/9] Add volume IDs from rhbz#1212599

[Zeeshan Ali (Khattak)]

On Wed, Sep 23, 2015 at 9:44 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Sep 17, 2015 at 01:01:35PM +0100, Zeeshan Ali (Khattak) wrote:
>> Hi,
>>
>> On Fri, Sep 11, 2015 at 5:21 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > https://bugzilla.redhat.com/show_bug.cgi?id=1212599 has a lot of test files
>> > which are not currently identified by libosinfo. This patch series adds most of
>> > these.
>>
>> Series looks good to me. One minor nitpick though: If you could write
>> "ID" instead of "id" and even "IDs" instead of "Ids", it would be best
>> IMHO. ACK either way.
>
> Changed and pushed, thanks.
>
>>
>> > One thing which I was not always sure about is what to make a Windows variant
>> > and what not. There are Debug Checked builds, Volume Licences builds, 'N'
>> > versions (without Windows Media Player), "with Updates" ISOs, ...
>> > Some of these I made first class variants, others I did not, but this was a bit
>> > arbitrary ;)
>>
>> Ideally I guess they are all variants but not sure we need to be so
>> specific, unless the info is needed by installer scripts.
>
> My goal would be to show the same label in libosinfo as the one on the
> Windows box/CD, even if the distinction is not useful to the installer
> scripts.

Ah, a worthy goal indeed. Although I can't be sure either how
perfectly we want to achieve this goal.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/