[Libosinfo] [PATCH v3 1/5] Use GTask instead of GSimpleAsyncResult

[Zeeshan Ali (Khattak)]

On Mon, Jan 11, 2016 at 2:05 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> Zeeshan
>
> On Mon, Jan 11, 2016 at 2:59 PM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
>> Hi fidencio,
>>
>> Thanks for doing this. Just some nits about commit log:
>>
>> On Mon, Jan 11, 2016 at 1:19 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
>>> Instead of using GSimpleAsyncResult, use the new GTask API, which is
>>> much more straightforward.
>>> For using the new GTask API, let's bump GIO (part of GLib) dependency
>>> version to 2.36.
>>
>> * I prefer to put version bump in separate patch, cause it kinda is a
>> separate change and it makes it hard to miss when writing release
>> notes.
>>
>> * Empty lines before each paragraph please. Not really your fault.
>> Seems this very annoying habit is getting widespread. :(
>>
>>> what is safe based on major distro support:
>>
>> The last line doesn't make sense grammatically (only questions start
>> with 'what') and "safe" IMO is vague and incorrect here. Just say "All
>> major distros have 2.36 or higher version available:"
>
> I appreciate your comments but unfortunately I've already pushed the
> series, sorry :-\

No biggie, just keep in mind in future. :)


-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/