[Libosinfo] [PATCH v1 6/6] win8, installer: Tune based on variants

[Zeeshan Ali (Khattak)]

Hi,

On Tue, May 3, 2016 at 10:42 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> The same issues faced when enabling the unattended installation for
> Windows 8.1 can be faced when performing a unattended installation for
> Windows 8.

Would be nice to describe the problem here. With shortlog also vague,
commit log isn't telling the most important bit.

 However, I wasn't been able to test the Windows 8
> Professional variant as it needs a VLK and MSDN tells me that only
> administrators can access kets in the Volume Licensing Service Center

I think you meant "keys" here?

> (VLSC). So, this patch has only been tested on No Variant and Enterprise
> variant of Windows 8. Any of the debug versions have been tested at all,

"Any" -> "None" or "All"?

> as the system reboots as soon as it boots, what seems like an ISO
> problem.

Just to be sure, by "ISO problem" you mean that ISO seems/is broken in
this regard?

> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>  data/install-script/microsoft.com/windows-unattend-desktop.xml.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/install-script/microsoft.com/windows-unattend-desktop.xml.in b/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
> index 310246f..a207c1d 100644
> --- a/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
> +++ b/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
> @@ -150,12 +150,12 @@
>           <UserData>
>            <AcceptEula>true</AcceptEula>
>            <xsl:choose>
> -            <xsl:when test="os/version != 6.3"> <!-- Any Windows, but the Windows 8.1 -->
> +            <xsl:when test="os/version < 6.2"> <!-- Windows 7 and older -->
>                <ProductKey>
>                  <Key><xsl:value-of select="config/reg-product-key"/></Key>
>                </ProductKey>
>              </xsl:when>
> -            <xsl:otherwise> <!-- Windows 8.1 -->
> +            <xsl:otherwise> <!-- Windows 8 and 8.1 -->
>                <xsl:if test="count(media/variant) = 0 or (contains(media/variant, 'debug') and not(contains(media/variant, 'enterprise')))"> <!-- "No Variant" or "Debug" variant -->
>                  <ProductKey>
>                    <Key><xsl:value-of select="config/reg-product-key"/></Key>
> --
> 2.7.3
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Regards,

Zeeshan Ali (Khattak)