[Libosinfo] [PATCH] win8,installer: Tune based on variants

[Zeeshan Ali (Khattak)]

On Thu, May 5, 2016 at 4:07 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> On Thu, May 5, 2016 at 5:04 PM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
>> On Wed, May 4, 2016 at 11:37 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
>>> As Windows 8.1, Windows 8 (most likely) has to have the ProductKey
>>> skipped during the WindowsPE phase of the script for the enterprise,
>>> enterprise-debug and professional variants.
>>> neither "debug variant".
>>
>> Surely you know that last sentence isn't really a proper sentence?
>
> Are you referring to "neither 'debug variant'"? It was a leftover,
> sorry, shouldn't be there at all.
>
>> Also you don't need to put "debug variant" in quotes here and please
>> keep empty lines between paragraphs.
>>
>>> Most likely is said because I haven't been able to test the Windows 8
>>
>> Save the quotes for "Most likely" here. :)
>
> Sure.
>
>>
>>> Professional variant as it needs a VLK and MSDN tells me that only
>>> administrators can access keys in the Volume Licensing Service Center
>>> (VLSC).
>>>
>>> Also, I haven't been able to start an installation using none of the
>>> debug ISOs, as the system reboots just a minute (or so) after booting
>>> up. It seems to be a problem with the ISOs themselves, as I've
>>> downloaded a few ISOs (different locales) and faced the same issue.
>>
>> Including the US lSO?
>
> None! :-\
>
>>
>>> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
>>> ---
>>>  data/install-script/microsoft.com/windows-unattend-desktop.xml.in | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/data/install-script/microsoft.com/windows-unattend-desktop.xml.in b/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
>>> index 310246f..a207c1d 100644
>>> --- a/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
>>> +++ b/data/install-script/microsoft.com/windows-unattend-desktop.xml.in
>>> @@ -150,12 +150,12 @@
>>>           <UserData>
>>>            <AcceptEula>true</AcceptEula>
>>>            <xsl:choose>
>>> -            <xsl:when test="os/version != 6.3"> <!-- Any Windows, but the Windows 8.1 -->
>>> +            <xsl:when test="os/version < 6.2"> <!-- Windows 7 and older -->
>>>                <ProductKey>
>>>                  <Key><xsl:value-of select="config/reg-product-key"/></Key>
>>>                </ProductKey>
>>>              </xsl:when>
>>> -            <xsl:otherwise> <!-- Windows 8.1 -->
>>> +            <xsl:otherwise> <!-- Windows 8 and 8.1 -->
>>>                <xsl:if test="count(media/variant) = 0 or (contains(media/variant, 'debug') and not(contains(media/variant, 'enterprise')))"> <!-- "No Variant" or "Debug" variant -->
>>>                  <ProductKey>
>>>                    <Key><xsl:value-of select="config/reg-product-key"/></Key>
>>> --
>>> 2.7.4
>>>
>>> _______________________________________________
>>> Libosinfo mailing list
>>> Libosinfo at redhat.com
>>> https://www.redhat.com/mailman/listinfo/libosinfo
>>
>>
>>
>> --
>> Regards,
>>
>> Zeeshan Ali (Khattak)
>
> All the other patches are acked? Shall I re-send the whole series?

Yeah, they look fine.

-- 
Regards,

Zeeshan Ali (Khattak)