[Libosinfo] [PATCH] win7, winxp: Upgrade spice-guest-tools to 0.100

[Fabiano Fidêncio]

On Thu, May 5, 2016 at 9:10 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> ---
>  data/os/microsoft.com/win-7.xml.in  | 8 ++++----
>  data/os/microsoft.com/win-xp.xml.in | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/data/os/microsoft.com/win-7.xml.in b/data/os/microsoft.com/win-7.xml.in
> index 2cb6488..8da4ccb 100644
> --- a/data/os/microsoft.com/win-7.xml.in
> +++ b/data/os/microsoft.com/win-7.xml.in
> @@ -205,8 +205,8 @@
>
>      <!-- All virtio and QXL device drivers, and spice-vdagent -->
>      <driver arch="i686" location="https://zeenix.fedorapeople.org/drivers/win-tools/postinst" signed="false">
> -      <file>spice-guest-tools-0.65.exe</file>
> -      <file>spice-guest-tools-0.65.cmd</file>
> +      <file>spice-guest-tools-0.100.exe</file>
> +      <file>spice-guest-tools-0.100.cmd</file>
>        <file>redhat09.cer</file>
>        <file>redhat10.cer</file>

I've noticed that these certificate files are not used anymore with
the spice-guest-tools-0.100. So, is there any reason for keeping those
files here?

>        <device id="http://pcisig.com/pci/1af4/1000"/>
> @@ -217,8 +217,8 @@
>      </driver>
>
>      <driver arch="x86_64" location="https://zeenix.fedorapeople.org/drivers/win-tools/postinst" signed="false">
> -      <file>spice-guest-tools-0.65.exe</file>
> -      <file>spice-guest-tools-0.65.cmd</file>
> +      <file>spice-guest-tools-0.100.exe</file>
> +      <file>spice-guest-tools-0.100.cmd</file>
>        <file>redhat09.cer</file>
>        <file>redhat10.cer</file>

Same here.

>        <device id="http://pcisig.com/pci/1af4/1000"/>
> diff --git a/data/os/microsoft.com/win-xp.xml.in b/data/os/microsoft.com/win-xp.xml.in
> index 3e181d9..e996cab 100644
> --- a/data/os/microsoft.com/win-xp.xml.in
> +++ b/data/os/microsoft.com/win-xp.xml.in
> @@ -87,8 +87,8 @@
>
>      <!-- All virtio and QXL device drivers, and spice-vdagent -->
>      <driver arch="i686" location="https://zeenix.fedorapeople.org/drivers/win-tools/postinst" signed="false">
> -      <file>spice-guest-tools-0.65.exe</file>
> -      <file>spice-guest-tools-0.65.cmd</file>
> +      <file>spice-guest-tools-0.100.exe</file>
> +      <file>spice-guest-tools-0.100.cmd</file>
>        <file>redhat09.cer</file>
>        <file>redhat10.cer</file>

Same here

>        <device id="http://pcisig.com/pci/1af4/1000"/>
> @@ -99,8 +99,8 @@
>      </driver>
>
>      <driver arch="x86_64" location="https://zeenix.fedorapeople.org/drivers/win-tools/postinst" signed="false">
> -      <file>spice-guest-tools-0.65.exe</file>
> -      <file>spice-guest-tools-0.65.cmd</file>
> +      <file>spice-guest-tools-0.100.exe</file>
> +      <file>spice-guest-tools-0.100.cmd</file>
>        <file>redhat09.cer</file>
>        <file>redhat10.cer</file>

Same here.

>        <device id="http://pcisig.com/pci/1af4/1000"/>
> --
> 2.5.5
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo

Also, spice-space.org provides a direct link for the latest driver[0],
what makes the maintainability easier. Why not start using that for
the spice-guest-tools?

Another question that comes to my mind is why don't we generate/keep
the .cmd file inside libosinfo as we do for the installation scripts?
I don't see a good point on asking the drivers provider to provide us
something like that, neither a good reason to avoid the official's
drivers provider and use a personal webpage just because of the .cmd
file.

[0]: http://www.spice-space.org/download/binaries/spice-guest-tools/spice-guest-tools-latest.exe

Best Regards,
--
Fabiano Fidêncio