[Libosinfo] [PATCH v2 02/10] win10: Group and adjust Education volume IDs

[Zeeshan Ali (Khattak)]

On Sun, May 8, 2016 at 10:45 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> These new volume IDs were added

But you are not adding new IDs (even if you're generalizing the
pattern to include more IDs). Also, please don't refer to change in
the patch itself in the past tense unless you make it obvious that you
are talking of change in the patch itself.

> based on mimicking the already known
> ones for x86 and x86_64.
>
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>  data/os/microsoft.com/win-10.xml.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/os/microsoft.com/win-10.xml.in b/data/os/microsoft.com/win-10.xml.in
> index 980898d..23fbea3 100644
> --- a/data/os/microsoft.com/win-10.xml.in
> +++ b/data/os/microsoft.com/win-10.xml.in
> @@ -22,7 +22,7 @@
>      <media arch="i686">
>        <variant id="education"/>
>        <iso>
> -        <volume-id>J_CEDA_X86FRE_</volume-id>
> +        <volume-id>J_CEDN?A_X86FRE_</volume-id>
>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language">[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>        </iso>
> @@ -30,7 +30,7 @@
>      <media arch="x86_64">
>        <variant id="education"/>
>        <iso>
> -        <volume-id>J_CEDNA_X64FRE_</volume-id>
> +        <volume-id>J_CEDN?A_X64FRE_</volume-id>
>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language">[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>        </iso>
> --
> 2.7.4
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Regards,

Zeeshan Ali (Khattak)