[Libosinfo] [osinfo-db] install-script, opensuse: Add omit-xml-declaration to the output format

[Fabiano Fidêncio]

On Fri, Apr 21, 2017 at 10:45 AM, Daniel P. Berrange
<berrange at redhat.com> wrote:
> On Fri, Apr 21, 2017 at 10:37:37AM +0200, Fabiano Fidêncio wrote:
>> Without this change the output got from the command-line template will
>> look like "<?xml version=1> autoyast=device://sda/autoinst.xml" while
>> what we actually expect is just "autoyast=device://sda/autoinst.xml".
>
> This description looks a bit odd - if I run
>
>   $ osinfo-install-script -p jeos  opensuse42.2
>
> it generates autoinst.xml, which contains
>
> <?xml version="1.0"?>
> <profile xmlns:config="http://www.suse.com/1.0/configns" xmlns="http://www.suse.com/1.0/yast2ns">
>   <bootloader>
>     <device_map config:type="list">
> ....snip....
>
> where is this
>
>  "<?xml version=1> autoyast=device://sda/autoinst.xm"
>
> data that you're referring to ?

You'll get it once you call
osinfo_install_script_generate_command_line_for_media().
The returned result depends on the output type set in for the XML file.

So, instead of getting the expected
"autoyast=device://sda/autoinst.xml" you'll get  "<?xml version=1>
autoyast=device://sda/autoinst.xml".

We never been hit by this because all the other install-scripts we
have are not XML files, but pure text files, while the openSUSE/SLES
one is actually a XML.

Also, for some reason, their installer never complained about this
issue before (probably they were parsing it out?) but it became a
problem for OpenSUSE 42.2+ and SLES 12.2+.

Hopefully it's clear.

>
>
>>
>> It's been the faulty part that caused problems with Tumbleweed and Leap
>> 42.2 installations.
>>
>> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
>> ---
>>  data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 2 +-
>>  data/install-script/opensuse.org/opensuse-autoyast-jeos.xml.in    | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>> index 75fc74d..6554eb6 100644
>> --- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>> +++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>> @@ -31,7 +31,7 @@
>>          xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
>>          version="1.0">
>>
>> -        <xsl:output method="xml" indent="yes"/>
>> +        <xsl:output method="xml" indent="yes" omit-xml-declaration="yes"/>
>>
>>          <xsl:template name="l10n-language">
>>            <xsl:choose>
>> diff --git a/data/install-script/opensuse.org/opensuse-autoyast-jeos.xml.in b/data/install-script/opensuse.org/opensuse-autoyast-jeos.xml.in
>> index fb42c50..0079cc5 100644
>> --- a/data/install-script/opensuse.org/opensuse-autoyast-jeos.xml.in
>> +++ b/data/install-script/opensuse.org/opensuse-autoyast-jeos.xml.in
>> @@ -22,7 +22,7 @@
>>          xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
>>          version="1.0">
>>
>> -        <xsl:output method="xml" indent="yes"/>
>> +        <xsl:output method="xml" indent="yes" omit-xml-declaration="yes"/>
>>
>>          <xsl:template name="l10n-language">
>>            <xsl:choose>
>> --
>> 2.9.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo at redhat.com
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fidêncio