[Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

[Roman Bogorodskiy]

  Christophe Fergeau wrote:

> On Sun, Apr 16, 2017 at 05:38:10PM +0400, Roman Bogorodskiy wrote:
> >   Daniel P. Berrange wrote:
> > 
> > > On Wed, Feb 08, 2017 at 07:46:50PM +0400, Roman Bogorodskiy wrote:
> > > >   Christophe Fergeau wrote:
> > > > 
> > > > > On Wed, Feb 08, 2017 at 05:37:27PM +0400, Roman Bogorodskiy wrote:
> > > > > >   Roman Bogorodskiy wrote:
> > > > > > 
> > > > > > > ---
> > > > > > >  data/os/freebsd.org/freebsd-11.0.xml.in | 50 +++++++++++++++++++++++++++++++++
> > > > > > >  1 file changed, 50 insertions(+)
> > > > > > >  create mode 100644 data/os/freebsd.org/freebsd-11.0.xml.in
> > > > > > > 
> > > > > > > diff --git a/data/os/freebsd.org/freebsd-11.0.xml.in b/data/os/freebsd.org/freebsd-11.0.xml.in
> > > > > > > new file mode 100644
> > > > > > > index 0000000..9af534f
> > > > > > > --- /dev/null
> > > > > > > +++ b/data/os/freebsd.org/freebsd-11.0.xml.in
> > > > > > 
> > > > > > ping?
> > > > > 
> > > > > Hey, thanks for the reminder, ACK and pushed! Would you have iso test
> > > > > data which we could add to libosinfo test suite? (isoinfo -d -i output)
> > > > 
> > > > Thanks!
> > > > 
> > > > I'll add the test, but need to figure out why the existing tests fail.
> > > 
> > > If tests fail it'll mostly likely be due to the tests picking up outdated
> > > content for osinfo-db. Setting OSINFO_SYSTEM_DIR ought to fix it
> > > generally.
> > 
> > Had no luck with that, still have "test-isodetect" failing:
> > 
> > Running suite(s): List
> > 0%: Checks: 14, Failures: 14, Errors: 0
> > test-isodetect.c:355:F:Core:test_fedora:0: ISO yarrow-i386-disc1.iso.txt was not matched by OS fedora1
> > test-isodetect.c:355:F:Core:test_rhel:0: ISO RHEL-Atomic-Host-Installer-7.0.0-Beta.iso.txt was not matched by OS rhel-atomic-7.0
> > ... and other 12 similar errors skipped ...
> > 
> > I've removed the osinfo related packages from my system and only have
> > things checked out using git in my home directory.
> > 
> > I've tried setting OSINFO_SYSTEM_DIR to "/path/to/osinfo-db/checkout"
> > and to "/path/to/osinfo-db/checkout/data" and it didn't help.
> > 
> > Also, when I do this, I try "./tools/osinfo-query os" and it shows empty
> > list as well.
> > 
> > I've also tried importing the database to my user directory:
> > 
> > ./osinfo-db-import --user ~/code/osinfo-db/osinfo-db-20170415.tar.xz
> > 
> > and then trying to set OSINFO_SYSTEM_DIR to `./osinfo-db-path --user`,
> > but it didn't help.
> > 
> > Before I debug this further, maybe I'm missing something obvious?
> 
> Just double check that make check passes for me with latest git. Maybe
> 'CK_FORK=no strace -e open ./test-isodetect' could give you a clue as to
> what's going on (at least this could confirm there are no old files
> lying around)

I tried that on Ubuntu 16.04 host and it worked fine for me too. But
when I'm using FreeBSD, it fails. There's no 'strace' on x86_64 FreeBSD,
but there's a similar tool called 'truss'. I tried to use it and grep
out open(2) calls and grep out 'freebsd.org' so I don't have too much
info to process:

OSINFO_SYSTEM_DIR="/home/novel/code/osinfo-db/data/" truss -f ./test/test-isodetect 2>&1|grep "open("|grep freebsd.org

And the only matches I see are just:

 2262: open("/home/novel/code/osinfo-db/data/os/freebsd.org",O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC,057) = 13 (0xd)

(a number of exactly the same calls, looks like it's matching the number
of tests).

"/home/novel/code/osinfo-db/data/os/freebsd.org" is the right dir, if I
do:
 
 ls /home/novel/code/osinfo-db/data/os/freebsd.org/*.xml

I can see a number of xml files there.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170427/57b84bc2/attachment.sig>