[Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

[Daniel P. Berrange]

On Thu, Apr 27, 2017 at 05:56:59PM +0100, Daniel P. Berrange wrote:
> On Thu, Apr 27, 2017 at 07:55:41PM +0400, Roman Bogorodskiy wrote:
> >   Daniel P. Berrange wrote:
> > 
> > > On Thu, Apr 27, 2017 at 06:56:58PM +0400, Roman Bogorodskiy wrote:
> > > > > Does it work if you make install to the "normal" location and
> > > > > unset OSINFO_SYSTEM_DIR ?
> > > > 
> > > > It does not, when I do './tools/osinfo-query os', it shows nothing.
> > > > 
> > > > However, if I use system version of libosinfo (1.0.0), it works.
> > > > Basically:
> > > > 
> > > > git version: ./tools/osinfo-query os --> empty
> > > > 1.0.0: osinfo-query os --> works fine
> > > > 
> > > > Also, when I try the OSINFO_SYSTEM_DIR trick with 1.0.0:
> > > > 
> > > > OSINFO_SYSTEM_DIR="/home/novel/code/osinfo-db/data/" osinfo-query os
> > > > 
> > > > it does work.
> > > > 
> > > > So it looks like some regression in the git version indeed.
> > > 
> > > Odd, because there are no changes to the loader code between 1.0.0 and
> > > current git master. It feels more like some aspect of the way it is
> > > built might be breaking it, but damned if I can see what that would
> > > be.
> > 
> > Heh, it was a trivial issue :-(
> > 
> > Apparently, osinfo_loader_process_list() fails if it cannot find pci.ids
> > or usb.ids. On FreeBSD it isn't installed to PKG_DATA_DIR where libosinfo
> > expects them to be. I set it with --with-usb-ids-path and
> > --with-pci-ids-path in the FreeBSD port, but didn't use these flags when
> > building from git. Now it works fine.

BTW, in configure.ac we have a list of locations we look for USB/PCI id
files. Please do add any standard FreeBSD location(s) to that list so
we just "do the right thing"

> Hmm, sounds like we have an error reporting bug though. if we fail to
> read pci.ids / usd.ids, we should propagage an error all the way back
> to the top. IOW, osinfo-query should immediately exit with an message
> saying it failed to load pci.ids, likewise for the test suite.

I sent a patch for this now.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|