[Libosinfo] [libosinfo] check-symsorting: don't hardcode Perl path

Daniel P. Berrange berrange at redhat.com
Wed Feb 8 16:13:07 UTC 2017


On Wed, Feb 08, 2017 at 07:50:10PM +0400, Roman Bogorodskiy wrote:
> Do not hardcode '/usr/bin/perl' because on FreeBSD and maybe some other
> systems it's installed in a different prefix, so use '/usr/bin/env perl'
> instead.
> ---
>  osinfo/check-symsorting.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl
> index 470247c..cc7b8d6 100755
> --- a/osinfo/check-symsorting.pl
> +++ b/osinfo/check-symsorting.pl
> @@ -1,4 +1,4 @@
> -#!/usr/bin/perl
> +#!/usr/bin/env perl
>  
>  # Copyright (C) 2012-2013 Red Hat, Inc.
>  #

Does this matter ? the Makefile.am rule is using $(PERL) to pick the
right emulator to run iiuc

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|




More information about the Libosinfo mailing list