[Libosinfo] [osinfo-db PATCH] Sort list of sources in POTFILES.in

Eric Blake eblake at redhat.com
Mon Mar 20 20:13:00 UTC 2017


On 03/20/2017 08:49 AM, Pino Toscano wrote:
> This way, the generation of osinfo-db.pot is more deterministic and
> stable, and it is way easier to diff pot files before and after editing
> the XML definitions of OSes, devices, etc.
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index a7a5c68..e2db764 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -81,7 +81,7 @@ clean:
>  	rm -f $(DATA_FILES) $(SCHEMA_FILES) po/POTFILES.in po/osinfo-db.pot
>  
>  po/POTFILES.in:
> -	$(V_GEN) find data -name *.xml.in > $@
> +	$(V_GEN) find data -name *.xml.in | sort > $@

Do you want to use 'LC_ALL=C sort' instead of locale-dependent 'sort',
to ensure that variations in the build environment locale don't affect
things?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170320/d23414f0/attachment.sig>


More information about the Libosinfo mailing list