[Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata

Roman Bogorodskiy bogorodskiy at gmail.com
Tue May 2 15:48:52 UTC 2017


  Daniel P. Berrange wrote:

> On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote:
> >   Christophe Fergeau wrote:
> > 
> > > 
> > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > and pushed.
> > 
> > Oops, it looks like it should be moved to 'tests' dir now (I generated
> > this patch before the rename).
> 
> I'll sort that.

Thanks!

> > Also, I've noticed that trailing whitespaces were stripped:
> > 
> > https://gitlab.com/libosinfo/libosinfo/commit/093d9cb73e40065d44656c53cff73d780589d686
> > 
> > Is that something some sort of post-processing that needs to be done
> > after running 'isoinfo -d -i'? Quick glance over isoinfo manpage does
> > not show how to make it strip whitespaces.
> 
> I stripped whitespace, otherwise "syntax-check" fails - I think we've
> always just done it manually.

Oh, weird, syntax-check doesn't fail for me (luckily, I still have a
branch with that commit as I sent it and before test -> tests). Maybe
yet another GNU and BSD grep (or whatever tool is used to find this)
incompatibilities. :-(

> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20170502/b127c6f0/attachment.sig>


More information about the Libosinfo mailing list