[Libosinfo] [PATCH] android-x86: Add Android-x86 8.1-rc2 (Oreo-x86)

Fabiano Fidêncio fidencio at redhat.com
Fri Dec 14 13:48:42 UTC 2018


Felipe,

On Fri, 2018-12-14 at 13:47 +0100, Felipe Borges wrote:
> Android-x86 is a project that intents to compose images to bring
> Android to the x86 platform.
> 
> See
> http://www.android-x86.org/releases/releasenote-8-1-rc2
> 
> Signed-off-by: Felipe Borges <feborges at redhat.com>
> ---
>  .../os/android-x86.org/android-x86-8.1.xml.in | 53
> +++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 data/os/android-x86.org/android-x86-8.1.xml.in
> 
> diff --git a/data/os/android-x86.org/android-x86-8.1.xml.in
> b/data/os/android-x86.org/android-x86-8.1.xml.in
> new file mode 100644
> index 0000000..8de4d7c
> --- /dev/null
> +++ b/data/os/android-x86.org/android-x86-8.1.xml.in
> @@ -0,0 +1,53 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or
> later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text
> -->
> +  <os id="http://android-x86.org/android/8.1-rc2">

About the os id:
- I'd go for 8.1 and leave it as prerelease instead of adding 8.1-rc2,
8.1-rc3, 8.1 ... Do you agree with the change?
- Do we want to have "android" or "android-x86" as the os name? By the
filename I'd say we should call it android-x86 ... Do you agree with
the cahnge?


> +    <short-id>android81</short-id>

If we do the two changes mentione above, the short-id would become:
android-x86-8.1

> +    <_name>Android-x86 8.1-rc2</_name>

The name would be Android-x86 8.1

> +    <version>8.1-rc2</version>

And the version 8.1

> +    <_vendor>Android-x86</_vendor>
> +    <family>linux</family>
> +    <distro>android-x86</distro>
> +    <codename>oreo-x86</codename>
> +
> +    <release-status>prerelease</release-status>

And this prerelease status is enough to show that it's a RC (or
something equivalent)

> +    <release-date>2018-10-18</release-date>

Then we can drop this "release-data" line.

[snip]

Please, let me know if you agree with the suggested changes and, if
yes, I'll push the patches with the changes. No need to submit a v2.

Thanks for the contribution!
--
Fabiano Fidêncio




More information about the Libosinfo mailing list