[Libosinfo] [osinfo-db-tools PATCH v4 2/3] import: Learn how to deal with URLs

Fabiano Fidêncio fidencio at redhat.com
Fri Dec 14 15:13:01 UTC 2018


On Fri, 2018-12-14 at 14:45 +0000, Daniel P. Berrangé wrote:
> On Fri, Dec 14, 2018 at 03:43:36PM +0100, Fabiano Fidêncio wrote:
> > > Rather than checking for URI schemes, can we just call
> > > g_file_is_native()
> > 
> > Changed locally.
> > 
> > > Also 'file' is no longer required but we've not unrefd it.
> > 
> > We do. We do it during the "cleanup" ...
> 
> No, it isn't.
> 
> The pointer in 'file' variable at this point is overwritten
> with a new pointer when reading the archive entries before
> we get to "cleanup".

Argh! You're right and I've missed that, twice.
It'll be fixed in v5.

[snip]

Best Regards,
-- 
Fabiano Fidêncio




More information about the Libosinfo mailing list