[Libosinfo] [PATCH] autogen: Don't hardcode --enable-gtk-doc

Daniel P. Berrangé berrange at redhat.com
Thu May 10 08:57:23 UTC 2018


On Wed, May 09, 2018 at 02:12:16PM +0200, Andrea Bolognani wrote:
> The usual behavior is for configure to detect the availability
> of gtk-doc, along with other optional features, and only enable
> it if found.
> 
> Hardcoding it this way is causing issues for MinGW builds,
> where pkg-config is looking in the MinGW-specific paths and
> can't locate the native gtk-doc.pc file, thus concluding
> gtk-doc must not be present and aborting the build altogether
> instead of simply skipping API reference generation.
> 
> Both 'make distcheck' (through the DISTCHECK_CONFIGURE_FLAGS
> variable) and the prepare-release.sh script are already
> enforcing the availability of gtk-doc when preparing releases,
> so it's safe to use the default behavior for regular builds.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  autogen.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the Libosinfo mailing list