[Libosinfo] [PATCH] endlessos: Add Endless OS 3.4

[Christophe Fergeau]

On Wed, May 23, 2018 at 11:26:31AM +0200, Felipe Borges wrote:
> Hi!
> 
> On Wed, May 23, 2018 at 11:02 AM, Christophe Fergeau
> <cfergeau at redhat.com> wrote:
> > Hey,
> >
> > On Tue, May 22, 2018 at 05:14:27PM +0200, Felipe Borges wrote:
> >> Signed-off-by: Felipe Borges <feborges at redhat.com>
> >> ---
> >>  data/os/endlessos.com/eos-3.4.xml.in | 199 +++++++++++++++++++++++++++
> >>  1 file changed, 199 insertions(+)
> >>  create mode 100644 data/os/endlessos.com/eos-3.4.xml.in
> >>
> >> diff --git a/data/os/endlessos.com/eos-3.4.xml.in b/data/os/endlessos.com/eos-3.4.xml.in
> >> new file mode 100644
> >> index 0000000..d06b328
> >> --- /dev/null
> >> +++ b/data/os/endlessos.com/eos-3.4.xml.in
> >> @@ -0,0 +1,199 @@
> >> +<libosinfo version="0.0.1">
> >> +<!-- Licensed under the GNU General Public License version 2 or later.
> >> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> >> +  <os id="http://endlessos.com/eos/3.4">
> >> +    <short-id>eos3.4</short-id>
> >> +    <_name>Endless OS 3.4</_name>
> >> +    <version>3.4</version>
> >> +    <_vendor>Endless Mobile, Inc</_vendor>
> >> +    <family>linux</family>
> >> +    <distro>eos</distro>
> >> +
> >> +    <release-date>2018-05-15</release-date>
> >> +
> >> +    <variant id="basic">
> >> +      <_name>Endless OS Basic</_name>
> >> +    </variant>
> >> +    <variant id="ar">
> >> +      <_name>Endless OS Arabic</_name>
> >> +    </variant>
> >> +    <variant id="bn">
> >> +      <_name>Endless OS Bengali</_name>
> >> +    </variant>
> >> +    <variant id="en">
> >> +      <_name>Endless OS English</_name>
> >> +    </variant>
> >> +    <variant id="es">
> >> +      <_name>Endless OS Spanish</_name>
> >> +    </variant>
> >> +    <variant id="es_GT">
> >> +      <_name>Endless OS Spanish (Guatemala)</_name>
> >> +    </variant>
> >> +    <variant id="es_MX">
> >> +      <_name>Endless OS Spanish (Mexico)</_name>
> >> +    </variant>
> >> +    <variant id="fr">
> >> +      <_name>Endless OS French</_name>
> >> +    </variant>
> >> +    <variant id="id">
> >> +      <_name>Endless OS Indonesian</_name>
> >> +    </variant>
> >> +    <variant id="pt_BR">
> >> +      <_name>Endless OS Portuguese (Brazil)</_name>
> >> +    </variant>
> >> +    <variant id="th">
> >> +      <_name>Endless OS Thai</_name>
> >> +    </variant>
> >> +    <variant id="vi">
> >> +      <_name>Endless OS Vietnamese</_name>
> >> +    </variant>
> >> +    <variant id="zh_CN">
> >> +      <_name>Endless OS Chinese (China)</_name>
> >> +    </variant>
> >> +
> >> +    <!-- Basic -->
> >> +    <media arch="x86_64" live="true">
> >> +      <variant id="basic"/>
> >> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/base/eos-eos3.4-amd64-amd64.180515-041823.base.iso</url>
> >> +      <iso>
> >> +        <volume-id>Endless-OS-3-4-0-base</volume-id>
> >> +        <volume-size>1867401216</volume-size>
> >> +      </iso>
> >> +    </media>
> >> +
> >> +    <!-- Arabic -->
> >> +    <media arch="x86_64" live="true">
> >> +      <variant id="ar"/>
> >> +      <url>https://d1anzknqnc1kmb.cloudfront.net/release/3.4.0/eos-amd64-amd64/ar/eos-eos3.4-amd64-amd64.180515-054338.ar.iso</url>
> >> +      <iso>
> >> +        <volume-id>Endless-OS-3-4-0-ar</volume-id>
> >> +        <volume-size>9225773056</volume-size>
> >
> > libosinfo has the concept of "language-map" in order to map some
> > language code in the volume id to some locale identifier, see the
> > data/os/microsoft.com/win-7.xml.in and
> > data/datamap/microsoft.com/win-7-l10n-language.xml.in for example,
> > imo it would be more appropriate to use that here rather than multiple
> > variants.
> 
> The reasoning behind the use of multiple variants is that Endless
> ships different content in each image. The Spanish, Mexican,
> Guatemalan "variants" have different content in it.
> 
> What do you think?

Are there ISOs with the same content, and whose only difference is their
language? Or is each language also getting some variations in the
available applications/...? This reasoning belongs in the commit log btw
;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20180523/33fb229a/attachment.sig>