[Libosinfo] [PATCH osinfo-db 00/10] usb3 and misc device tweaks

Cole Robinson crobinso at redhat.com
Mon Oct 1 14:05:33 UTC 2018


On 10/01/2018 02:56 AM, Fabiano Fidêncio wrote:
> On Fri, 2018-09-28 at 14:25 -0400, Cole Robinson wrote:
>> This series is a collection of device annotation cleanups,
>> improvements, and additions.
>>
>> 1-4 are cleanups
>> 5-7 add more annotations for existing devices
>> 8-10 add usb3 device annotations
>>
>> Thanks,
>> Cole
> 
> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
> 
> And I'm also pushing this series.
> 

Thanks!

> Cole, checking those devices manually seems to be a not so nice work to
> do and also quite error prone (in the way that we may just add more
> duplications at any time). I do believe that having a test for this
> would be the ideal situation. What do you think? In case you don't have
> time to work on this, would you mind filling a bug some we can at least
> keep track of this?
> 

Yeah tracking this is hard right now. I wrote a script to do a text dump 
of an os, its devices and resources. Attached below. I was thinking of 
adding something like 'osinfo-query dump <short-id>' to do the same thing.

Adding a test to catch duplicates is definitely a good idea. I will file 
a bug, but where? I realized last week we have bugzilla.redhat.com 
product=Virtualization Tools component=libosinfo, but there's also the 
issue tracker in gitlab that has some reports as well.

I don't have any strong preference for either: bugzilla is more a part 
of my workflow but its less discoverable and more overhead for new 
contributors. I think we should pick one though and disable the other

Thanks,
Cole
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osinfo-print-all.py
Type: text/x-python
Size: 2207 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20181001/4227ea4b/attachment.py>


More information about the Libosinfo mailing list