[Libosinfo] [PATCH osinfo-db 00/10] usb3 and misc device tweaks
Cole Robinson
crobinso at redhat.com
Mon Oct 1 16:45:21 UTC 2018
On 10/01/2018 10:16 AM, Fabiano Fidêncio wrote:
> On Mon, 2018-10-01 at 10:05 -0400, Cole Robinson wrote:
>> On 10/01/2018 02:56 AM, Fabiano Fidêncio wrote:
>>> On Fri, 2018-09-28 at 14:25 -0400, Cole Robinson wrote:
>>>> This series is a collection of device annotation cleanups,
>>>> improvements, and additions.
>>>>
>>>> 1-4 are cleanups
>>>> 5-7 add more annotations for existing devices
>>>> 8-10 add usb3 device annotations
>>>>
>>>> Thanks,
>>>> Cole
>>>
>>> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
>>>
>>> And I'm also pushing this series.
>>>
>>
>> Thanks!
>>
>>> Cole, checking those devices manually seems to be a not so nice
>>> work to
>>> do and also quite error prone (in the way that we may just add more
>>> duplications at any time). I do believe that having a test for this
>>> would be the ideal situation. What do you think? In case you don't
>>> have
>>> time to work on this, would you mind filling a bug some we can at
>>> least
>>> keep track of this?
>>>
>>
>> Yeah tracking this is hard right now. I wrote a script to do a text
>> dump
>> of an os, its devices and resources. Attached below. I was thinking
>> of
>> adding something like 'osinfo-query dump <short-id>' to do the same
>> thing.
>>
>> Adding a test to catch duplicates is definitely a good idea. I will
>> file
>> a bug, but where? I realized last week we have bugzilla.redhat.com
>> product=Virtualization Tools component=libosinfo, but there's also
>> the
>> issue tracker in gitlab that has some reports as well.
>
> It's not so easy to keep track right now.
>
> New contributors would, for sure, prefer to have the issues in gitlab
> (and some already complained that we don't accept Merge-Requests there
> as well).
>
> I, personally, think that we should stick to the bugzilla.redhat.com
> product=Virtualization Tools component=libosinfo/osinfo-db/osinfo-db-
> tools.
>
> Anyways, if you could, please, create a bug in bugzilla.redhat.com
> then!
Done: https://bugzilla.redhat.com/show_bug.cgi?id=1634807
Thanks,
Cole
More information about the Libosinfo
mailing list