[Libosinfo] [PATCH libosinfo 0/3] Add SUSE CaaS Platform isodata

[Fabiano Fidêncio]

Charles,

On Wed, Oct 3, 2018 at 10:08 PM Charles Arnold <carnold at suse.com> wrote:
>
> >>> On 10/3/2018 at 01:45 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> > Charles.
> >
> > On Wed, Oct 3, 2018 at 9:21 PM Charles Arnold <carnold at suse.com> wrote:
> >>
> >> There have been three releases.
> >>
> >> Charles Arnold (3):
> >>   Add SUSE CaaS Platform 1.0 isodata
> >>   Add SUSE CaaS Platform 2.0 isodata
> >>   Add SUSE CaaS Platform 3.0 isodata
> >>
> >
> > Those changes broke test-isodetect and it happened because the
> > directory which contains the isodata should match the short-id of the
> > OS.
> > So, for instance, instead of caasp10, it should be named caasp1.0.
> >
> > There's no need to submit a v2, I can do the changes manually before
> > pushing the patches (and I'll push those after your feedback on the
> > osinfo-db series).
>
> Thank you!

I've pushed both series with the modifications I've mentioned and
here's a short recap:
- osinfo-db:
  - Added the <eol-date> for caasp1.0 and caasp2.0
  - Added <upgrades id="..."/> for caasp2.0 and caasp3.0
- libosinfo:
  - Changed the isodata's directories to match the caasp short-ids:
    - caasp10 -> caasp1.0
    - caasp20 -> caasp2.0
    - caasp30 -> caasp3.0

>
> >
> > A kind unrelated topic (but not so much) ... I've noticed that
> > openSUSE also keeps one downstream patch for a Windows volume id.
> > Would be possible for you to also send that upstream? That would make
> > our life easier wrt maintaining opensuse package.
>
> I will get that one ready and submit.

Thanks, that would be really nice!

Best Regards,
-- 
Fabiano Fidêncio