[Libosinfo] [PATCH osinfo-db v2 4/5] os: Add q35/e1000e/ich9 for win2k8r2+ and win7+

[Cole Robinson]

On 10/04/2018 03:44 AM, Fabiano Fidêncio wrote:
> On Fri, 2018-09-28 at 18:55 -0400, Cole Robinson wrote:
>> I haven't explicitly tested either of these. However there's been
>> users
>> of win7 and q35 in the wild, mostly for vga passthrough AFAICT, so
>> this
>> should work. win2k8r2 is roughly the same vintage as win7
>>
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> ---
>>   data/os/microsoft.com/win-2k8r2.xml.in | 6 ++++++
>>   data/os/microsoft.com/win-7.xml.in     | 3 +++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/data/os/microsoft.com/win-2k8r2.xml.in
>> b/data/os/microsoft.com/win-2k8r2.xml.in
>> index 2edb169..71a7172 100644
>> --- a/data/os/microsoft.com/win-2k8r2.xml.in
>> +++ b/data/os/microsoft.com/win-2k8r2.xml.in
>> @@ -14,6 +14,12 @@
>>       <release-date>2009-10-22</release-date>
>>       <eol-date>2013-07-09</eol-date>
>>   
>> +    <devices>
>> +      <device id="http://pcisig.com/pci/8086/29c0"/> <!-- q35 -->
>> +      <device id="http://pcisig.com/pci/8086/10d3"/> <!-- e1000e -->
>> +      <device id="http://pcisig.com/pci/8086/293e"/> <!-- ich9 -->
>> +    </devices>
>> +
>>       <media arch="x86_64">
>>         <iso>
>>           <volume-id>(GRMSXVOL|GRMSXFRER|GRMSHXVOL)_</volume-id>
>> diff --git a/data/os/microsoft.com/win-7.xml.in
>> b/data/os/microsoft.com/win-7.xml.in
>> index fc196a0..0ae1868 100644
>> --- a/data/os/microsoft.com/win-7.xml.in
>> +++ b/data/os/microsoft.com/win-7.xml.in
>> @@ -182,6 +182,9 @@
>>   
>>       <devices>
>>         <device id="http://pcisig.com/pci/8086/2668"/> <!-- ich6 -->
>> +      <device id="http://pcisig.com/pci/8086/29c0"/> <!-- q35 -->
>> +      <device id="http://pcisig.com/pci/8086/10d3"/> <!-- e1000e -->
>> +      <device id="http://pcisig.com/pci/8086/293e"/> <!-- ich9 -->
>>       </devices>
>>   
>>       <installer>
> 
> In your cover-letter you stated that this combo (q35+e1000e+ich9)
> wasn't extensively tested. May I assume that it was tested on this
> case? :-)
> 

It's not so much the combo of q35+e1000e+ich9 specifically, more the 
combo of windows+q35. I personally haven't done much more than boot 
testing, but virt stack developers assure me the combo works and there's 
a lot of user reports. I'll do more testing over the next few working 
days though

- Cole