[Libosinfo] [PATCH osinfo-db 1/3] device: Add chipset q35

Daniel P. Berrangé berrange at redhat.com
Wed Oct 10 15:51:34 UTC 2018


On Tue, Oct 09, 2018 at 11:13:32AM -0400, Cole Robinson wrote:
> Introduce a new URI scheme and class chipset.virtual, rather
> than attach this to any particular PCI ID.
> 
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
>  data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in | 8 ++++++++
>  data/schema/osinfo.rng.in                              | 1 +
>  2 files changed, 9 insertions(+)
>  create mode 100644 data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in

> diff --git a/data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in b/data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in
> new file mode 100644
> index 0000000..6920c67
> --- /dev/null
> +++ b/data/device/qemu.org/chipset-x86_64-q35.d/class.xml.in
> @@ -0,0 +1,8 @@
> +<libosinfo version="0.0.1">
> +<!-- Licensed under the GNU General Public License version 2 or later.
> +     See http://www.gnu.org/licenses/ for a copy of the license text -->
> +  <device id="http://qemu.org/chipset/x86_64/q35">

q35 works on i686 and x86_64 so I wonder if we should use a '/x86/'
prefix. Duplicating the device for both archs feels overkill.

> +    <name>q35</name>
> +    <class>chipset.virtual</class>
> +  </device>
> +</libosinfo>
> diff --git a/data/schema/osinfo.rng.in b/data/schema/osinfo.rng.in
> index fa09249..fc45dbd 100644
> --- a/data/schema/osinfo.rng.in
> +++ b/data/schema/osinfo.rng.in
> @@ -77,6 +77,7 @@
>                <value>audio</value>
>                <value>block</value>
>                <value>console</value>
> +              <value>chipset.virtual</value>
>                <value>controller.usb</value>
>                <value>filesystem</value>
>                <value>input</value>
> -- 
> 2.19.0
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the Libosinfo mailing list