[Libosinfo] [PATCH osinfo-db v4 5/5] os: Add q35/ich9/e1000e to rhel6

[Daniel P. Berrangé]

On Wed, Oct 10, 2018 at 02:37:24PM -0400, Cole Robinson wrote:
> rhel6 does support q35, it just has some issues when combined with
> virtio, as rhel6 doesn't support virtio1.0
> 
> https://ladipro.wordpress.com/2016/10/17/virtio1-0-and-windows-guests/
> 
> However that decision should be left up to apps and not mandated by
> osinfo metadata.
> 
> Add this annotation for rhel6 to ensure apps aren't naively depending
> solely on the presence of qemu-x86-q35 in the device list, and instead
> checking for specific virtio support as well
> 
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> See the virt-manager patch for usage:
> 
> https://github.com/crobinso/virt-manager/commit/3d34ca2ee926ef45ddb85edeb41e34ceb91c6d2d
> 
> The logic is:
> 
> def supports_q35():
>     if has_virtio_net and not has_virtio1_net:
>         return False
>     return has_q35
> 
> virtio_net/virtio1_net here is basically a proxy for
> virtio/virtio1 support as a whole. This will match rhel7,
> but not rhel6 which lacks virtio1 support, but will also
> match all windows OS. I don't know how this logic will apply
> to gnome-boxes though which uses virtio for windows, but
> via autoinstall scripts, I'm not really sure how that all
> fits together
> 
>  data/os/redhat.com/rhel-6.0.xml.in | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|