[Libosinfo] [PATCH osinfo-db v4 0/5] Add q35 chipset

[Cole Robinson]

On 10/11/2018 01:27 AM, Fabiano Fidêncio wrote:
> Cole,
> 
> On Wed, Oct 10, 2018 at 8:37 PM Cole Robinson <crobinso at redhat.com> wrote:
>>
>> v1 posting:
>> https://www.redhat.com/archives/libosinfo/2018-August/msg00006.html
>> v2 posting:
>> https://www.redhat.com/archives/libosinfo/2018-September/msg00162.html
>> v3 posting:
>> https://www.redhat.com/archives/libosinfo/2018-October/msg00075.html
>>
>> v4 changes:
>>      - add patch for s/ich9/ich9-hda/
>>      - s/x86_64/x86/ in q35 qemu.org URI
>>      - s/chipset.virtual/chipset/ for q35 <class>
>>      - add last patch with rhel6 annotation
>>
>> Unpushed virt-manager commit using this:
>> https://github.com/crobinso/virt-manager/commit/3d34ca2ee926ef45ddb85edeb41e34ceb91c6d2d
>>
>> See patch #5 for a breakdown of the expected app logic for
>> consuming this
>>
>> Cole Robinson (5):
>>    device: rename 'ich9' to 'ich9-hda'
>>    device: Add chipset qemu-x86-q35
>>    os: Add q35/e1000e/ich9 for win2k8r2+ and win7+
>>    os: Add q35/ich9/e1000e alongside virtio1.0 <device>
>>    os: Add q35/ich9/e1000e to rhel6
>>
>>   data/device/pcisig.com/pci-8086-293e.d/class.xml.in | 2 +-
>>   data/device/qemu.org/chipset-x86-q35.xml.in         | 8 ++++++++
>>   data/os/debian.org/debian-9.xml.in                  | 3 +++
>>   data/os/fedoraproject.org/fedora-23.xml.in          | 5 ++++-
>>   data/os/microsoft.com/win-2k8r2.xml.in              | 6 ++++++
>>   data/os/microsoft.com/win-7.xml.in                  | 3 +++
>>   data/os/opensuse.org/opensuse-42.2.xml.in           | 3 +++
>>   data/os/redhat.com/rhel-6.0.xml.in                  | 6 ++++++
>>   data/os/redhat.com/rhel-7.2.xml.in                  | 3 +++
>>   data/os/suse.com/sled-12.2.xml.in                   | 3 +++
>>   data/os/suse.com/sles-12.2.xml.in                   | 3 +++
>>   data/os/ubuntu.com/ubuntu-17.04.xml.in              | 3 +++
>>   data/schema/osinfo.rng.in                           | 1 +
>>   13 files changed, 47 insertions(+), 2 deletions(-)
>>   create mode 100644 data/device/qemu.org/chipset-x86-q35.xml.in
>>
>> --
>> 2.19.0
>>
> 
> Series look good. There's one minor comment in the 4th patch, please,
> fix it before pushing.
> 
> About how it's going to work with Boxes plus express installation,
> well, I'll be finding this out during the next few days.
> 
> Please, wait for Dan's ACK as well (although, IMO, the series
> addresses all his comments).
> 
> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
> 

Adjusted and pushed now

Thanks,
Cole

- Cole