[Libosinfo] [osinfo-db-tools PATCH 0/2] Dependency check for tests deps

[Cole Robinson]

On 4/9/19 12:30 PM, Fabiano Fidêncio wrote:
> As the subject says, this patch set adds a dependency check for our
> tests, only executing them when this dependency check is successful.
> 
> The dependency check is done in configure.ac and the needed deps have
> also been added to our spec file (together with the "check" target).
> 
> The checks do not look the cleanest solution ever and I'm open for
> suggestions on how to properly handle those deps on configure.ac
> 
> Fabiano Fidêncio (2):
>   tests: Only run the tests if deps are installed
>   spec: Add %check target (and the needed deps)
> 
>  configure.ac            | 23 +++++++++++++++++++++++
>  osinfo-db-tools.spec.in | 20 ++++++++++++++++++++
>  tests/Makefile.am       |  6 +++++-
>  3 files changed, 48 insertions(+), 1 deletion(-)
> 

Seems a bit strange that a missing dep makes test suite appear to
succeed but actually doesn't run anything (well it reports running 0
tests but there's no indication anything is missing). I don't know if it
really matters for this case though. For the code:

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole