[Libosinfo] [osinfo-db PATCH v2 0/7] Fix out-of-tree builds

[Cole Robinson]

On 4/23/19 11:20 AM, Fabiano Fidêncio wrote:
> In order to fix out-of-tree builds we need to:
> - do not consider source (.xml.in) and generated (.xml) files are in the same
>   directory;
>   - with this, some changes have to be done in order to properly run
>     _check_uncommended_devices() test
> - set the proper environmnet variables for INTERNAL_OSINFO_DB_DATA_DIR and
>   OSINFO_DB_DATA_SRC_DIR when calling pytest.
> - call pytest pointint to the tests directory
> 
> As we don't rely on autoconf, ABS_TOPDIR has been added to our Makefile.
> 
> Guido, would you mind to give it a try? It did fix the issue for me, but
> I'd like to be sure it also fixes the issue for you.
> 
> Please, mind that you'll need to have python3, python3-pytest, python3-lxml,
> and python3-request installed.
> 
> Fabiano Fidêncio (7):
>   tests: Add _Files() base class
>   tests: Move ids_cb() out of os_parametrize()
>   tests: Add _SourceFiles() class
>   tests: Move _check_uncommended_devices() to its own test
>   tests: Add INTERNAL_OSINFO_DB_DATA_SRC_DIR to conftest
>   makefile: Fix out-of-tree build
>   makefile: Remove unused "TEE" variable
> 
>  Makefile              |  6 ++---
>  tests/conftest.py     |  5 ++++
>  tests/test_devices.py | 10 ++++---
>  tests/util.py         | 62 ++++++++++++++++++++++++++++++++-----------
>  4 files changed, 62 insertions(+), 21 deletions(-)
> 

Works for my workflow and code looks fine, I didn't test vpath build
though so Guido should confirm

Reviewed-by: Cole Robinson <crobinso at redhat.com>

Thanks,
Cole