[Libosinfo] [PATCH osinfo-db 0/2] Add SLE12-SP5 Information to the Database

[Fabiano Fidêncio]

Charles,

On Wed, Dec 11, 2019 at 7:13 PM Charles Arnold <carnold at suse.com> wrote:
>
> Add SUSE Linux Enterprise Server and Desktop description and
> isodata files for version 12-SP5.
>
> Charles Arnold (2):
>   Add SLE12-SP5 to the database
>   Added SLE12-SP5 isodata to the database

Please, change:
Added -> Add

Apart from this, two comments:
- We started requiring that all contributors to assert that
contributions are in compliance with the terms of the Developer's
Certificate of Origin 1.1 (https://developercertificate.org/). In
order to indicate compliance every commit must have a tag
  Signed-off-by: REAL NAME <EMAIL>
This can be achieved by passing the "-s" flag to the "git commit" command.
To update all commits on the current branch to add a Signed-off-by tag, use
  git rebase -i master -x 'git commit --amend --no-edit -s'

- We need to update the -unknown entries as well. I've cooked a patch
for this so you don't have to do so. However, I'd like to have your
ack on the changes:
```
>From c161eb72c1d7a16d77c966d5cfb29e9c2c6b054d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio at redhat.com>
Date: Thu, 12 Dec 2019 11:33:58 +0100
Subject: [PATCH] sle[ds]-12-unknown: Update after 12.5 release
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
---
 data/os/suse.com/sled-12-unknown.xml.in |  6 +++---
 data/os/suse.com/sles-12-unknown.xml.in | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/data/os/suse.com/sled-12-unknown.xml.in
b/data/os/suse.com/sled-12-unknown.xml.in
index ff2f56d3..defcaad9 100644
--- a/data/os/suse.com/sled-12-unknown.xml.in
+++ b/data/os/suse.com/sled-12-unknown.xml.in
@@ -8,13 +8,13 @@
     <_vendor>SUSE</_vendor>
     <family>linux</family>
     <distro>sled</distro>
-    <upgrades id="http://suse.com/sled/12.4"/>
-    <derives-from id="http://suse.com/sled/12.4"/>
+    <upgrades id="http://suse.com/sled/12.5"/>
+    <derives-from id="http://suse.com/sled/12.5"/>

     <media arch="x86_64">
       <iso>
         <system-id>LINUX</system-id>
-        <volume-id>SLE-12-SP[5-9]-Desktop-DVD-x86_64</volume-id>
+        <volume-id>SLE-12-SP[6-9]-Desktop-DVD-x86_64</volume-id>
       </iso>
       <kernel>boot/x86_64/loader/linux</kernel>
       <initrd>boot/x86_64/loader/initrd</initrd>
diff --git a/data/os/suse.com/sles-12-unknown.xml.in
b/data/os/suse.com/sles-12-unknown.xml.in
index ee2b975a..4f128580 100644
--- a/data/os/suse.com/sles-12-unknown.xml.in
+++ b/data/os/suse.com/sles-12-unknown.xml.in
@@ -8,13 +8,13 @@
     <_vendor>SUSE</_vendor>
     <family>linux</family>
     <distro>sles</distro>
-    <upgrades id="http://suse.com/sles/12.4"/>
-    <derives-from id="http://suse.com/sles/12.4"/>
+    <upgrades id="http://suse.com/sles/12.5"/>
+    <derives-from id="http://suse.com/sles/12.5"/>

     <media arch="x86_64">
       <iso>
         <system-id>LINUX</system-id>
-        <volume-id>SLE-12-SP[5-9]-Server-DVD-x86_64</volume-id>
+        <volume-id>SLE-12-SP[6-9]-Server-DVD-x86_64</volume-id>
       </iso>
       <kernel>boot/x86_64/loader/linux</kernel>
       <initrd>boot/x86_64/loader/initrd</initrd>
@@ -23,7 +23,7 @@
     <media arch="aarch64">
       <iso>
         <system-id>LINUX</system-id>
-        <volume-id>SLE-12-SP[5-9]-Server-DVD-aarch64</volume-id>
+        <volume-id>SLE-12-SP[6-9]-Server-DVD-aarch64</volume-id>
       </iso>
       <kernel>boot/aarch64/linux</kernel>
       <initrd>boot/aarch64/initrd</initrd>
@@ -32,7 +32,7 @@
     <media arch="ppc64">
       <iso>
         <system-id>LINUX</system-id>
-        <volume-id>SLE-12-SP[5-9]-Server-DVD-ppc64le</volume-id>
+        <volume-id>SLE-12-SP[6-9]-Server-DVD-ppc64le</volume-id>
       </iso>
       <kernel>boot/ppc64le/linux</kernel>
       <initrd>boot/ppc64le/initrd</initrd>
@@ -41,7 +41,7 @@
     <media arch="s390x">
       <iso>
         <system-id>LINUX</system-id>
-        <volume-id>SLE-12-SP[5-9]-Server-DVD-s390x</volume-id>
+        <volume-id>SLE-12-SP[6-9]-Server-DVD-s390x</volume-id>
       </iso>
       <kernel>boot/s390x/linux</kernel>
       <initrd>boot/s390x/initrd</initrd>
-- 
2.23.0
```