[Libosinfo] [osinfo-db PATCH 8/9] centos: Add "centos7" as short-id

Cole Robinson crobinso at redhat.com
Mon Feb 18 18:06:18 UTC 2019


On 2/18/19 2:58 AM, Fabiano Fidêncio wrote:
> 
> 
> On Thu, Feb 14, 2019 at 6:28 PM Cole Robinson <crobinso at redhat.com
> <mailto:crobinso at redhat.com>> wrote:
> 
>     On 12/21/18 9:09 AM, Fabiano Fidêncio wrote:
>     > Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com
>     <mailto:fidencio at redhat.com>>
>     > ---
>     >  data/os/centos.org/centos-7.0.xml.in
>     <http://centos.org/centos-7.0.xml.in> | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/data/os/centos.org/centos-7.0.xml.in
>     <http://centos.org/centos-7.0.xml.in>
>     b/data/os/centos.org/centos-7.0.xml.in
>     <http://centos.org/centos-7.0.xml.in>
>     > index 8b3531e..cc583b9 100644
>     > --- a/data/os/centos.org/centos-7.0.xml.in
>     <http://centos.org/centos-7.0.xml.in>
>     > +++ b/data/os/centos.org/centos-7.0.xml.in
>     <http://centos.org/centos-7.0.xml.in>
>     > @@ -3,6 +3,7 @@
>     >       See http://www.gnu.org/licenses/ for a copy of the license
>     text -->
>     >    <os id="http://centos.org/centos/7.0">
>     >      <short-id>centos7.0</short-id>
>     > +    <short-id>centos7</short-id>
>     >      <_name>CentOS 7.0</_name>
>     >      <version>7.0</version>
>     >      <_vendor>CentOS</_vendor>
>     >
> 
>     Huh I didn't know we could do that, but I see we do the same for debian
>     distros, so it makes sense
> 
> 
> Cole, I will end up dropping this patch.
> While we can do that (as in our schema allows that), there's no code on
> libosinfo that would properly deal with a second short-id.
> 
> So, for now, I'll not go for this patch.

Hmm indeed, I made a note for myself to look into this and besides being
allowed in the XML, and there being some ubuntu/debian data examples, I
can't see any way to access the second short-id via the API. Too bad,
would be helpful in some cases for sure

- Cole




More information about the Libosinfo mailing list