[Libosinfo] [osinfo-db PATCH] silverblue, ks: quote keyboard's argument

Cole Robinson crobinso at redhat.com
Tue Jan 15 20:41:17 UTC 2019


On 01/15/2019 03:02 PM, Fabiano Fidêncio wrote:
> keyboard command (from kickstart) receives a single parameter as
> argument, thus whatever we receive as l10n-keyboard must be quoted as
> applications may just set things as 'in (eng)'.
> 
> The same approach is already taken on Fedora kickstarts.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1666320
> 
> Signed-off-by: Fabiano Fidêncio <fabiano at fidencio.org>
> ---
>   .../fedoraproject.org/silverblue-kickstart-desktop.xml.in               | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> index c38f17f..71cd40e 100644
> --- a/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> +++ b/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> @@ -41,7 +41,7 @@
>           <xsl:template match="/install-script-config">
>   # Install script for <xsl:value-of select="os/short-id"/> profile <xsl:value-of select="script/profile"/>
>   install
> -keyboard <xsl:value-of select="config/l10n-keyboard"/>
> +keyboard '<xsl:value-of select="config/l10n-keyboard"/>'
>   lang <xsl:value-of select="config/l10n-language"/>
>   network --onboot yes --bootproto dhcp --noipv6 --hostname=<xsl:value-of select="config/hostname"/>
>   rootpw dummyPa55w0rd # Actual password set (or unset) in %post below
> 

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the Libosinfo mailing list