[Libosinfo] [osinfo-db PATCH 0/2] Fix infinite loop on libosinfo side & add tests to avoid this to happen again
Cole Robinson
crobinso at redhat.com
Sat Jun 1 16:59:43 UTC 2019
On 5/29/19 8:15 AM, Fabiano Fidêncio wrote:
> This series fixes the infinite loop caused by a typo in openbsd-6.3
> entry and also adds a test avoiding this issue to happen in the future.
>
> Fabiano Fidêncio (2):
> openbsd-6.3: Fix derives-from
> tests: Add test_related
>
> data/os/openbsd.org/openbsd-6.3.xml.in | 2 +-
> tests/test_related.py | 12 ++++++++++++
> tests/util.py | 5 ++++-
> 3 files changed, 17 insertions(+), 2 deletions(-)
> create mode 100644 tests/test_related.py
>
Reviewed-by: Cole Robinson <crobinso at redhat.com>
Ideas for future test improvements:
* Check all references in the chain, there could be circular references.
Maybe just try to resolve them all and a hanging test will make it clear
something is wrong, or python will throw a recursion error.
* validate the referenced id is valid (which libosinfo will assert on
but we could catch it earlier here)
- Cole
More information about the Libosinfo
mailing list